Add Elastic Agent in the Jenkinsfile#17445
Merged
ph merged 2 commits intoelastic:masterfrom Apr 3, 2020
ph:agent/ci-allow-agent-ci-to-be-build
Merged
Add Elastic Agent in the Jenkinsfile#17445ph merged 2 commits intoelastic:masterfrom ph:agent/ci-allow-agent-ci-to-be-build
ph merged 2 commits intoelastic:masterfrom
ph:agent/ci-allow-agent-ci-to-be-build
Conversation
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
michalpristas
approved these changes
Apr 2, 2020
Contributor
michalpristas
left a comment
There was a problem hiding this comment.
aside from typos looks good, please fix before merge
With the recent moves to Jenkins pipeline the Elastic Agent project was not currently tested.
Contributor
Author
|
@michalpristas I've created this issue #17449, we don't our logic right when we deal with joining path for the install hooks. I've disabled the test here. |
andrewkroh
approved these changes
Apr 3, 2020
| {"/a", "/a/b/c", "\\a\\b\\c", true}, | ||
| {"/a", "/A/b/c", "\\a\\b\\c", true}, | ||
| }, | ||
| // (Windows issue) See issue: |
Contributor
Contributor
Author
|
Jenkins test this please |
Contributor
Author
|
jenkins run the tests please |
Contributor
Author
|
I am going to merge this as is, and fallback on travis for everything mac related. |
Contributor
Author
|
backported in #17599 |
ph
added a commit
that referenced
this pull request
Apr 14, 2020
) * [Agent] Rename agent to elastic-agent (#17391) [Agent] Rename agent to elastic-agent (#17391) (cherry picked from commit 66609a3) * Add Elastic Agent in the Jenkinsfile (#17445) * Add Elastic Agent in the Jenkinsfile With the recent moves to Jenkins pipeline the Elastic Agent project was not currently tested. * Add Elastic Agent in the Jenkinsfile (#17445) * Add Elastic Agent in the Jenkinsfile With the recent moves to Jenkins pipeline the Elastic Agent project was not currently tested. * [Agent] Fix merge of config (#17399) [Agent] Fix merge of config #17399 * [Agent] Handle abs paths on windows correctly (#17461) * handle windows correctly * Missing commits from the initial merges of the agent -> master Co-authored-by: Michal Pristas <michal.pristas@gmail.com> Co-authored-by: Pier-Hugues Pellerin <phpellerin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With the recent moves to Jenkins pipeline the Elastic Agent project was
not currently tested.
Why is it important?
To run the tests for the project.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues