Skip to content

Building functionbeat providers with specific GOOS and GOARCH#15586

Merged
ycombinator merged 3 commits intoelastic:masterfrom
rvillablanca:fix/functionbeat-build-providers-2
Jan 22, 2020
Merged

Building functionbeat providers with specific GOOS and GOARCH#15586
ycombinator merged 3 commits intoelastic:masterfrom
rvillablanca:fix/functionbeat-build-providers-2

Conversation

@rvillablanca
Copy link
Copy Markdown
Contributor

@rvillablanca rvillablanca commented Jan 15, 2020

This is a replace for the PR #15399 to solve the issue #15132.

I have added the fields GOOS and GOARCH to ProviderDetails so we can now build the providers with for specific platforms. This fields are optional so the old behaviour is kept.

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 15, 2020

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@rvillablanca rvillablanca requested a review from kvch January 15, 2020 16:50
@rvillablanca rvillablanca mentioned this pull request Jan 15, 2020
Closed
@kvch
Copy link
Copy Markdown
Contributor

kvch commented Jan 16, 2020

jenkins test this

@kvch
Copy link
Copy Markdown
Contributor

kvch commented Jan 17, 2020

jenkins test this

@kvch
Copy link
Copy Markdown
Contributor

kvch commented Jan 17, 2020

@rvillablanca The failing functionbeat tests are seem related to your change. Could you please take a look at those? Let me know if you need help with making the tests pass.

@rvillablanca
Copy link
Copy Markdown
Contributor Author

rvillablanca commented Jan 17, 2020

Sure I will investigate @kvch

@rvillablanca
Copy link
Copy Markdown
Contributor Author

rvillablanca commented Jan 17, 2020

The problem is Travis is running under darwin os and cross-compiling is having some issues so there is no way (at the moment I think) to build for linux under darwin. A workaround would be to create a specific task to build in test with darwin os, what do you think @kvch ?

@ycombinator
Copy link
Copy Markdown
Contributor

ycombinator commented Jan 21, 2020

Hey @rvillablanca @kvch WDYT about incorporating 483a1f2 into this PR? It seems to fix the issue on Travis CI for the Functionbeat job.

@rvillablanca
Copy link
Copy Markdown
Contributor Author

rvillablanca commented Jan 22, 2020 •
edited
Loading

LGTM @kvch

@rvillablanca
Copy link
Copy Markdown
Contributor Author

rvillablanca commented Jan 22, 2020

I want to cherry-pick it but not sure where I can find that commit 😆

@ycombinator ycombinator mentioned this pull request Jan 22, 2020
Merged
@ycombinator
Copy link
Copy Markdown
Contributor

ycombinator commented Jan 22, 2020

I want to cherry-pick it but not sure where I can find that commit 😆

I wanted to see what you thought of that change, first. Since you're okay with it, I put up a PR with that change to your PR here: rvillablanca#1. If you merge it, the commit will show up over here in this PR.

@ycombinator
Copy link
Copy Markdown
Contributor

ycombinator commented Jan 22, 2020

jenkins, test this

kvch
kvch reviewed Jan 22, 2020
View reviewed changes
@rvillablanca rvillablanca force-pushed the fix/functionbeat-build-providers-2 branch from 55d3cb3 to 4265a12 Compare January 22, 2020 16:55
@ycombinator
Copy link
Copy Markdown
Contributor

ycombinator commented Jan 22, 2020

jenkins, test this

ycombinator
ycombinator approved these changes Jan 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will merge once CI looks good.

@ycombinator
Copy link
Copy Markdown
Contributor

ycombinator commented Jan 22, 2020

CI failures are unrelated to this PR. Merging.

Thanks for the contribution, @rvillablanca ❤️!

@ycombinator ycombinator merged commit 4dd18e0 into elastic:master Jan 22, 2020
@ycombinator ycombinator added Functionbeat needs_backport PR is waiting to be backported to other branches. v7.7.0 v8.0.0 labels Jan 22, 2020
@ycombinator ycombinator mentioned this pull request Jan 22, 2020
Merged
@ycombinator ycombinator removed the needs_backport PR is waiting to be backported to other branches. label Jan 22, 2020
@rvillablanca
Copy link
Copy Markdown
Contributor Author

rvillablanca commented Jan 22, 2020

Happy to help

@rvillablanca rvillablanca deleted the fix/functionbeat-build-providers-2 branch January 22, 2020 18:50
@ycombinator ycombinator mentioned this pull request Jan 23, 2020
Closed
ycombinator added a commit that referenced this pull request Jan 28, 2020
@ycombinator @rvillablanca
Building functionbeat providers with specific GOOS and GOARCH (#15586) (
dd971a3 
#15753)

* Building functionbeat providers with specific GOOS and GOARCH

* Fix: os changed to linux for aws functionbeat provider

* Disabling CGO in functionbeat because it is not used

Co-authored-by: Rodrigo Villablanca Vásquez <villa061004@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ycombinator ycombinator ycombinator approved these changes

+1 more reviewer

@kvch kvch kvch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Functionbeat v7.7.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rvillablanca @elasticmachine @kvch @ycombinator