Functionbeat providers compilation with specific GOOS and GOARCH#15399
Closed
rvillablanca wants to merge 4 commits intoelastic:masterfrom
Closed
Functionbeat providers compilation with specific GOOS and GOARCH#15399rvillablanca wants to merge 4 commits intoelastic:masterfrom
rvillablanca wants to merge 4 commits intoelastic:masterfrom
Conversation
Contributor
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Contributor
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
houndci-bot
reviewed
Jan 8, 2020
Contributor
Author
|
@ycombinator 👀 😆 |
Contributor
|
@rvillablanca Could you please rebase the PR? |
Contributor
Author
|
I can but I was reviewing and I think it is better to apply my changes on top of this because the intention was almost the same, so it is easier to re-make the changes @kvch |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal to fix the issue #15132, which describes the problem when generating the functionbeat for providers (currently only aws).
How this works
Now the
SelectedProvidersis a slice of objects containing the required info of the provider:So when building the providers, the
params.Envis written with that information so now we can build the beat for a required os/arch.