[DOCS] More fixes for asciidoctor migration#12434
Merged
dedemorton merged 3 commits intoelastic:masterfrom Jun 25, 2019
Merged
Conversation
andrewkroh
reviewed
Jun 5, 2019
nik9000
reviewed
Jun 5, 2019
Member
nik9000
left a comment
There was a problem hiding this comment.
The asciidoc changes make sense to me!
Contributor
Author
|
I think this is ready to merge. I don't think there is an easy way to test the asciidoctor builds without backporting to all branches first, but I did compare the HTML before/after to make sure the output is correct in the asciidoc build. |
Contributor
Author
|
jenkins test this again please |
52828bd to
4a4a8f2
Compare
cachedout
approved these changes
Jun 11, 2019
afd35ab to
5d6562a
Compare
5d6562a to
054b799
Compare
DStape
pushed a commit
to DStape/beats
that referenced
this pull request
Aug 20, 2019
* [DOCS] More fixes for asciidoctor migration * Simplify logic for adding delimiter blocks * Rebase and run make update
52 tasks
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Aug 31, 2019
* [DOCS] More fixes for asciidoctor migration * Simplify logic for adding delimiter blocks * Rebase and run make update
dedemorton
added a commit
that referenced
this pull request
Sep 4, 2019
* Asciidoctor migration (#12006) * Change tagging to work with asciidoctor * Fix formatting issues * Changes from review * [DOCS] More fixes for asciidoctor migration (#12434) * [DOCS] More fixes for asciidoctor migration * Simplify logic for adding delimiter blocks * Rebase and run make update * Revert incorrect fix * Update script to fix broken list format * Fix script to pass autopep8 test
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Sep 5, 2019
* Asciidoctor migration (elastic#12006) * Change tagging to work with asciidoctor * Fix formatting issues * Changes from review * [DOCS] More fixes for asciidoctor migration (elastic#12434) * [DOCS] More fixes for asciidoctor migration * Simplify logic for adding delimiter blocks * Rebase and run make update * Revert incorrect fix * Update script to fix broken list format * Fix script to pass autopep8 test
dedemorton
added a commit
that referenced
this pull request
Sep 5, 2019
* [7.1][DOCS] Backport: Fix asciidoctor build (#13460) * Asciidoctor migration (#12006) * Change tagging to work with asciidoctor * Fix formatting issues * Changes from review * [DOCS] More fixes for asciidoctor migration (#12434) * [DOCS] More fixes for asciidoctor migration * Simplify logic for adding delimiter blocks * Rebase and run make update * Revert incorrect fix * Update script to fix broken list format * Fix script to pass autopep8 test * Run make update * Fix code formatting * Remove attributes not used in this branch * Remove unwanted section added during backport * Revert to 6.8 version of journalbeat example
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* Asciidoctor migration (elastic#12006) * Change tagging to work with asciidoctor * Fix formatting issues * Changes from review * [DOCS] More fixes for asciidoctor migration (elastic#12434) * [DOCS] More fixes for asciidoctor migration * Simplify logic for adding delimiter blocks * Rebase and run make update * Revert incorrect fix * Update script to fix broken list format * Fix script to pass autopep8 test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes asciidoc coding issues that break the asciidoctor build.
Remaining to do:
Compare asciidoc build output to asciidoctor build output to see what's different and make changes, as required.removed because this testing needs to happen after all the changes are merged and backported.