Merged
Conversation
Member
|
I haven't checked the logic but I love this way of removing the complex
conditionals!
…On Tue, Apr 30, 2019, 21:25 DeDe Morton ***@***.***> wrote:
First pass - removes complex conditionals, but there are still many errors
when I build this (and it looks like a lot of the errors are caused by
asciidoc files that we generate).
------------------------------
You can view, comment on, or merge this pull request online at:
#12006
Commit Summary
- Change tagging to work with asciidoctor
- Fix formatting issues
File Changes
- *M* docs/devguide/migrate-dashboards.asciidoc
<https://github.com/elastic/beats/pull/12006/files#diff-0> (4)
- *M* docs/devguide/newdashboards.asciidoc
<https://github.com/elastic/beats/pull/12006/files#diff-1> (12)
- *M* filebeat/docs/index.asciidoc
<https://github.com/elastic/beats/pull/12006/files#diff-2> (6)
- *M* journalbeat/docs/index.asciidoc
<https://github.com/elastic/beats/pull/12006/files#diff-3> (1)
- *M* libbeat/docs/command-reference.asciidoc
<https://github.com/elastic/beats/pull/12006/files#diff-4> (19)
- *M* libbeat/docs/outputconfig.asciidoc
<https://github.com/elastic/beats/pull/12006/files#diff-5> (32)
- *M* libbeat/docs/processors-using.asciidoc
<https://github.com/elastic/beats/pull/12006/files#diff-6> (14)
- *M* libbeat/docs/security/securing-beats.asciidoc
<https://github.com/elastic/beats/pull/12006/files#diff-7> (1)
- *M* libbeat/docs/shared-central-management.asciidoc
<https://github.com/elastic/beats/pull/12006/files#diff-8> (2)
- *M* libbeat/docs/shared-docker.asciidoc
<https://github.com/elastic/beats/pull/12006/files#diff-9> (58)
- *M* libbeat/docs/shared-path-config.asciidoc
<https://github.com/elastic/beats/pull/12006/files#diff-10> (2)
- *M* libbeat/docs/step-configure-output.asciidoc
<https://github.com/elastic/beats/pull/12006/files#diff-11> (6)
- *M* metricbeat/docs/index.asciidoc
<https://github.com/elastic/beats/pull/12006/files#diff-12> (2)
- *M* winlogbeat/docs/index.asciidoc
<https://github.com/elastic/beats/pull/12006/files#diff-13> (3)
Patch Links:
- https://github.com/elastic/beats/pull/12006.patch
- https://github.com/elastic/beats/pull/12006.diff
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#12006>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABUXIWED3DCVYIOPIATBP3PTDWQDANCNFSM4HJRI2JQ>
.
|
Contributor
Author
|
Incidentally, if you find out that the problems are caused by the formatting that we use in the "Exported fields" topic...we would like to change the layout anyhow (could be a win-win). Here's what I've proposed: #9519 (POC is here: https://github.com/dedemorton/beats-docs-review/pull/2/files). We should figure out what they've done with ECS and build on that. Eventually we want to pull a lot of the descriptions from the ECS docs, but not sure we want to get all those things figured out before we migrate to asciidoctor. Just an FYI.... |
nik9000
suggested changes
May 1, 2019
Member
nik9000
left a comment
There was a problem hiding this comment.
I think I found two things to change. I'm not totally sure though.
DStape
pushed a commit
to DStape/beats
that referenced
this pull request
Aug 20, 2019
* Change tagging to work with asciidoctor * Fix formatting issues * Changes from review
52 tasks
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Aug 31, 2019
* Change tagging to work with asciidoctor * Fix formatting issues * Changes from review
dedemorton
added a commit
that referenced
this pull request
Sep 4, 2019
* Asciidoctor migration (#12006) * Change tagging to work with asciidoctor * Fix formatting issues * Changes from review * [DOCS] More fixes for asciidoctor migration (#12434) * [DOCS] More fixes for asciidoctor migration * Simplify logic for adding delimiter blocks * Rebase and run make update * Revert incorrect fix * Update script to fix broken list format * Fix script to pass autopep8 test
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Sep 5, 2019
* Asciidoctor migration (elastic#12006) * Change tagging to work with asciidoctor * Fix formatting issues * Changes from review * [DOCS] More fixes for asciidoctor migration (elastic#12434) * [DOCS] More fixes for asciidoctor migration * Simplify logic for adding delimiter blocks * Rebase and run make update * Revert incorrect fix * Update script to fix broken list format * Fix script to pass autopep8 test
dedemorton
added a commit
that referenced
this pull request
Sep 5, 2019
* [7.1][DOCS] Backport: Fix asciidoctor build (#13460) * Asciidoctor migration (#12006) * Change tagging to work with asciidoctor * Fix formatting issues * Changes from review * [DOCS] More fixes for asciidoctor migration (#12434) * [DOCS] More fixes for asciidoctor migration * Simplify logic for adding delimiter blocks * Rebase and run make update * Revert incorrect fix * Update script to fix broken list format * Fix script to pass autopep8 test * Run make update * Fix code formatting * Remove attributes not used in this branch * Remove unwanted section added during backport * Revert to 6.8 version of journalbeat example
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* Asciidoctor migration (elastic#12006) * Change tagging to work with asciidoctor * Fix formatting issues * Changes from review * [DOCS] More fixes for asciidoctor migration (elastic#12434) * [DOCS] More fixes for asciidoctor migration * Simplify logic for adding delimiter blocks * Rebase and run make update * Revert incorrect fix * Update script to fix broken list format * Fix script to pass autopep8 test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First pass - removes complex conditionals, but there are still many errors when I build this (and it looks like a lot of the errors are caused by asciidoc files that we generate).