Cherry-pick #12063 to 7.1: Fix memory leak in Filebeat pipeline acker#12137
Merged
exekias merged 2 commits intoelastic:7.1from May 10, 2019
Merged
Cherry-pick #12063 to 7.1: Fix memory leak in Filebeat pipeline acker#12137exekias merged 2 commits intoelastic:7.1from
exekias merged 2 commits intoelastic:7.1from
Conversation
* Fix memory leak in Filebeat pipeline acker Before this change acker goroutine was kept forever as processed events count was not correctly updated. Filebeat sends an empty event to update file states, this event is not published, but treated as dropped, without updating counters. This change makes sures that `a.events` count gets updated for dropped events also, so the acker gets closed after all ACKs happen. (cherry picked from commit 9653105)
jsoriano
approved these changes
May 9, 2019
urso
approved these changes
May 9, 2019
kaiyan-sheng
approved these changes
May 9, 2019
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…e acker (elastic#12137) * Fix memory leak in Filebeat pipeline acker (elastic#12063) * Fix memory leak in Filebeat pipeline acker Before this change acker goroutine was kept forever as processed events count was not correctly updated. Filebeat sends an empty event to update file states, this event is not published, but treated as dropped, without updating counters. This change makes sures that `a.events` count gets updated for dropped events also, so the acker gets closed after all ACKs happen. (cherry picked from commit 9dc1f39) * Update CHANGELOG.next.asciidoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #12063 to 7.1 branch. Original message:
Before this change acker goroutine was kept forever as processed events
count was not correctly updated.
Filebeat sends an empty event to update file states, this event is not
published, but treated as dropped, without updating counters.
This change makes sures that
a.eventscounter is updated for droppedevents too, so the acker gets closed (and freed) after all ACKs happen.
Original work by @jsoriano (#11810), and input from @urso, thank you both!