Stop gap ACK worker if no events are pending when done#11810
Closed
jsoriano wants to merge 1 commit intoelastic:masterfrom
Closed
Stop gap ACK worker if no events are pending when done#11810jsoriano wants to merge 1 commit intoelastic:masterfrom
jsoriano wants to merge 1 commit intoelastic:masterfrom
Conversation
If worker is not stopped when acker is done and there are no events pending it will never stop, leaking goroutines.
Member
Author
|
I still see the number of ackLoop goroutines increasing with this patch, we will have to take a deeper look around this. |
kvch
approved these changes
Apr 15, 2019
Member
Author
|
I am closing this by now as it doesn't seem to solve the issue. |
This was referenced May 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If worker is not stopped when acker is done and there are no events
pending it will never stop, leaking goroutines.
Related to #9302