add transaction.id to errors#437
Conversation
|
@graphaelli nice work! |
|
@roncohen that makes sense now, pushed up a commit for that. One side-effect is that |
|
As the @graphaelli This will need a rebase. |
|
I think you will have to rebase anyways even with #443 as the union is not in this PR yet and Github will not retrigger (I think). |
427120d to
e1af590
Compare
|
taking your word for it, rebased & force pushed |
tests/data/valid/error/payload.json
Outdated
| } | ||
| ] | ||
| ], | ||
| "transaction": { |
There was a problem hiding this comment.
I believe this should be inside the elements in errors. Agents can buffer up errors from different transactions
There was a problem hiding this comment.
ugh, my mistake, that makes much more sense.
to connect errors to transactions. closes elastic#409
a925c25 to
758411c
Compare
| mapping := []Mapping{ | ||
| {"errors.context", "context"}, | ||
| {"transactions.context", "context"}, | ||
| {"errors.transaction.id", "transaction.id"}, |
There was a problem hiding this comment.
@roncohen: I wasn't that comfortable with this, any way to do this better?
There was a problem hiding this comment.
Making sure i got this correctly: The test checks that everything that get stored as a keyword has the length restriction and vice-versa. We use this mapping to map the json schema names to the final elasticssearch document names. If that's correct, i don't have a better way to do it that what you did here.
There was a problem hiding this comment.
That's how I understand that test as well, thanks for verifying.
* add error.transaction.id to connect errors to transactions. closes elastic#409 * move error.transaction.id to root of error * allow each error in batch to belong to a separate transaction
to connect errors to transactions. closes #409