Skip to content

use merge=union for changelog#443

Merged
roncohen merged 1 commit intoelastic:masterfrom
graphaelli:changelog-merge
Dec 27, 2017
Merged

use merge=union for changelog#443
roncohen merged 1 commit intoelastic:masterfrom
graphaelli:changelog-merge

Conversation

@graphaelli
Copy link
Copy Markdown
Member

from the docs:
Run 3-way file level merge for text files, but take lines from both
versions, instead of leaving conflict markers. This tends to leave the
added lines in the resulting file in random order and the user should
verify the result. Do not use this if you do not understand the
implications.

from the docs:
  Run 3-way file level merge for text files, but take lines from both
  versions, instead of leaving conflict markers. This tends to leave the
  added lines in the resulting file in random order and the user should
  verify the result. Do not use this if you do not understand the
  implications.
@graphaelli
Copy link
Copy Markdown
Member Author

Before, got this merge conflict:

--- a/CHANGELOG.asciidoc
+++ b/CHANGELOG.asciidoc
@@@ -20,7 -19,7 +20,11 @@@ https://github.com/elastic/apm-server/c
  ==== Added
  - Support for uploading sourcemaps {pull}302[302].
  - app.environment {pull}366[366]
++<<<<<<< HEAD
 +- Add context.request.url.full {pull}436[436]
++=======
+ - Add error.transaction.id {pull}437[437]
++>>>>>>> add error.transaction.id

After, no conflict, changelog ended up like:

==== Added
- Support for uploading sourcemaps {pull}302[302].
- app.environment {pull}366[366]
- Add context.request.url.full {pull}436[436]
- Add error.transaction.id {pull}437[437]

@ruflin
Copy link
Copy Markdown
Contributor

ruflin commented Dec 26, 2017

We use the same on the beats side: https://github.com/elastic/beats/blob/master/.gitattributes The only problem we encounter from time to time on cherry picks for backports that some lines are "sneaked" in. Meaning an other line is added to the commit which should not be there. But that is normally catched with the review.

@roncohen roncohen merged commit 3a0780a into elastic:master Dec 27, 2017
simitt pushed a commit to simitt/apm-server that referenced this pull request Jan 8, 2018
from the docs:
  Run 3-way file level merge for text files, but take lines from both
  versions, instead of leaving conflict markers. This tends to leave the
  added lines in the resulting file in random order and the user should
  verify the result. Do not use this if you do not understand the
  implications.
@graphaelli graphaelli deleted the changelog-merge branch January 9, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants