processor/otel: set outcome from status code#4127
Merged
axw merged 3 commits intoelastic:masterfrom Sep 2, 2020
Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
For HTTP transactions/spans, set outcome to success or failure. For transactions we set to success for codes < 500, and for spans we set to success for codes < 400, in line with our own agents.
jalvz
approved these changes
Sep 1, 2020
axw
added a commit
to axw/apm-server
that referenced
this pull request
Sep 8, 2020
* processor/otel: set outcome from status code For HTTP transactions/spans, set outcome to success or failure. For transactions we set to success for codes < 500, and for spans we set to success for codes < 400, in line with our own agents. * Add constants for event.outcome
axw
added a commit
that referenced
this pull request
Sep 8, 2020
* processor/otel: set outcome from status code For HTTP transactions/spans, set outcome to success or failure. For transactions we set to success for codes < 500, and for spans we set to success for codes < 400, in line with our own agents. * Add constants for event.outcome
Contributor
|
successfully tested;
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/summary
For Jaeger HTTP transactions/spans, set outcome to success or failure.
For transactions we set to success for codes < 500, and for spans we set
to success for codes < 400, in line with our own agents.
Checklist
I have considered changes for:
- [ ] documentation- [ ] logging (add log lines, choose appropriate log selector, etc.)- [ ] metrics and monitoring (create issue for Kibana team to add metrics to visualizations, e.g. Kibana#44001)- [ ] telemetry- [ ] Elasticsearch Service (https://cloud.elastic.co)- [ ] Elastic Cloud Enterprise (https://www.elastic.co/products/ece)- [ ] Elastic Cloud on Kubernetes (https://www.elastic.co/elastic-cloud-kubernetes)How to test these changes
Instrument a web service that receives and sends HTTP requests with Jaeger. Send spans to APM Server, observe that
event.outcomeis added to the transactions and spans according to the HTTP status codes.Related issues
Closes #4117