Skip to content

[7.x] processor/otel: set outcome from status code (#4127)#4169

Merged
axw merged 1 commit intoelastic:7.xfrom
axw:backport/7.x/pr-4127
Sep 8, 2020
Merged

[7.x] processor/otel: set outcome from status code (#4127)#4169
axw merged 1 commit intoelastic:7.xfrom
axw:backport/7.x/pr-4127

Conversation

@axw
Copy link
Copy Markdown
Member

@axw axw commented Sep 8, 2020

Backports the following commits to 7.x:

@axw
processor/otel: set outcome from status code (elastic#4127)
2ce50a1 
* processor/otel: set outcome from status code

For HTTP transactions/spans, set outcome to success or failure.
For transactions we set to success for codes < 500, and for spans
we set to success for codes < 400, in line with our own agents.

* Add constants for event.outcome
@axw axw added the backport label Sep 8, 2020
@ghost
Copy link
Copy Markdown

ghost commented Sep 8, 2020

💔 Tests Failed

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #4169 opened]

  • Start Time: 2020-09-08T02:38:30.114+0000

  • Duration: 29 min 44 sec

Test stats 🧪

Test Results
Failed 1
Passed 3014
Skipped 139
Total 3154

Test errors

Expand to view the tests failures

  • Name: Build and Test / OSX build-test / TestAggregatorRun – spanmetrics

    • Age: 1
    • Duration: 0.02
    • Error Details: Failed

Steps errors

Expand to view the steps failures

  • Name: Compress

    • Description: tar --exclude=coverage-files.tgz -czf coverage-files.tgz coverage

    • Duration: 0 min 0 sec

    • Start Time: 2020-09-08T02:54:31.172+0000

    • log

  • Name: Compress

    • Description: tar --exclude=system-tests-linux-files.tgz -czf system-tests-linux-files.tgz system-tests

    • Duration: 0 min 0 sec

    • Start Time: 2020-09-08T03:07:11.419+0000

    • log

  • Name: Test Sync

    • Description: ./script/jenkins/sync.sh

    • Duration: 3 min 57 sec

    • Start Time: 2020-09-08T02:48:36.207+0000

    • log

Log output

Expand to view the last 100 lines of log output 

[2020-09-08T03:03:46.519Z] go: downloading github.com/golang/protobuf v1.3.4
[2020-09-08T03:03:46.779Z] go: downloading google.golang.org/genproto v0.0.0-20200218151345-dad8c97a84f5
[2020-09-08T03:03:46.779Z] go: downloading github.com/gogo/googleapis v1.0.1-0.20180501115203-b23578765ee5
[2020-09-08T03:03:46.779Z] go: downloading github.com/opentracing/opentracing-go v1.1.0
[2020-09-08T03:03:47.044Z] go: downloading golang.org/x/text v0.3.2
[2020-09-08T03:07:08.729Z] apm-server_kibana_1 is up-to-date
[2020-09-08T03:07:08.729Z] apm-server_elasticsearch_1 is up-to-date
[2020-09-08T03:07:08.729Z] === RUN   TestAPIKeyCreate
[2020-09-08T03:07:08.729Z] 2020/09/08 03:04:16 Building apm-server...
[2020-09-08T03:07:08.729Z] go: downloading github.com/aws/aws-sdk-go-v2 v0.9.0
[2020-09-08T03:07:08.729Z] go: downloading github.com/jmespath/go-jmespath v0.0.0-20180206201540-c2b33e8439af
[2020-09-08T03:07:08.729Z] 2020/09/08 03:06:30 Built /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-4169/src/github.com/elastic/apm-server/apm-server
[2020-09-08T03:07:08.729Z] --- PASS: TestAPIKeyCreate (136.46s)
[2020-09-08T03:07:08.729Z] === RUN   TestAPIKeyCreateExpiration
[2020-09-08T03:07:08.729Z] --- PASS: TestAPIKeyCreateExpiration (2.02s)
[2020-09-08T03:07:08.729Z] === RUN   TestAPIKeyInvalidateName
[2020-09-08T03:07:08.729Z] --- PASS: TestAPIKeyInvalidateName (3.05s)
[2020-09-08T03:07:08.729Z] === RUN   TestAPIKeyInvalidateID
[2020-09-08T03:07:08.729Z] --- PASS: TestAPIKeyInvalidateID (2.01s)
[2020-09-08T03:07:08.729Z] === RUN   TestAPMServerEnvironment
[2020-09-08T03:07:08.729Z] === RUN   TestAPMServerEnvironment/container
[2020-09-08T03:07:08.729Z] === PAUSE TestAPMServerEnvironment/container
[2020-09-08T03:07:08.729Z] === RUN   TestAPMServerEnvironment/systemd
[2020-09-08T03:07:08.729Z] === PAUSE TestAPMServerEnvironment/systemd
[2020-09-08T03:07:08.729Z] === RUN   TestAPMServerEnvironment/macos_service
[2020-09-08T03:07:08.729Z] === PAUSE TestAPMServerEnvironment/macos_service
[2020-09-08T03:07:08.729Z] === RUN   TestAPMServerEnvironment/windows_service
[2020-09-08T03:07:08.729Z] === PAUSE TestAPMServerEnvironment/windows_service
[2020-09-08T03:07:08.729Z] === CONT  TestAPMServerEnvironment/container
[2020-09-08T03:07:08.729Z] === CONT  TestAPMServerEnvironment/macos_service
[2020-09-08T03:07:08.729Z] === CONT  TestAPMServerEnvironment/systemd
[2020-09-08T03:07:08.729Z] === CONT  TestAPMServerEnvironment/windows_service
[2020-09-08T03:07:08.729Z] --- PASS: TestAPMServerEnvironment (0.00s)
[2020-09-08T03:07:08.729Z]     --- PASS: TestAPMServerEnvironment/systemd (0.43s)
[2020-09-08T03:07:08.729Z]     --- PASS: TestAPMServerEnvironment/macos_service (0.45s)
[2020-09-08T03:07:08.729Z]     --- PASS: TestAPMServerEnvironment/windows_service (0.49s)
[2020-09-08T03:07:08.729Z]     --- PASS: TestAPMServerEnvironment/container (0.50s)
[2020-09-08T03:07:08.729Z] === RUN   TestAPMServerInstrumentation
[2020-09-08T03:07:08.729Z] --- PASS: TestAPMServerInstrumentation (2.93s)
[2020-09-08T03:07:08.729Z] === RUN   TestJaegerGRPC
[2020-09-08T03:07:08.729Z] --- PASS: TestJaegerGRPC (2.42s)
[2020-09-08T03:07:08.729Z] === RUN   TestJaegerGRPCSampling
[2020-09-08T03:07:08.729Z] --- PASS: TestJaegerGRPCSampling (2.05s)
[2020-09-08T03:07:08.729Z] === RUN   TestAPMServerRequestLoggingValid
[2020-09-08T03:07:08.729Z] --- PASS: TestAPMServerRequestLoggingValid (0.27s)
[2020-09-08T03:07:08.729Z] === RUN   TestAPMServerMonitoring
[2020-09-08T03:07:08.729Z] --- PASS: TestAPMServerMonitoring (2.28s)
[2020-09-08T03:07:08.729Z] === RUN   TestAPMServerMonitoringBuiltinUser
[2020-09-08T03:07:08.729Z] --- PASS: TestAPMServerMonitoringBuiltinUser (1.92s)
[2020-09-08T03:07:08.729Z] === RUN   TestAPMServerOnboarding
[2020-09-08T03:07:08.729Z] --- PASS: TestAPMServerOnboarding (2.15s)
[2020-09-08T03:07:08.729Z] PASS
[2020-09-08T03:07:08.729Z] ok  	github.com/elastic/apm-server/systemtest	159.092s
[2020-09-08T03:07:08.729Z] === RUN   TestAPMServer
[2020-09-08T03:07:08.729Z] 2020/09/08 03:04:14 Building apm-server...
[2020-09-08T03:07:08.729Z] go: downloading github.com/elastic/elastic-agent-client/v7 v7.0.0-20200709172729-d43b7ad5833a
[2020-09-08T03:07:08.729Z] go: downloading github.com/elastic/go-hdrhistogram v0.1.0
[2020-09-08T03:07:08.729Z] go: downloading github.com/aws/aws-sdk-go-v2 v0.9.0
[2020-09-08T03:07:08.729Z] go: downloading github.com/ua-parser/uap-go v0.0.0-20200325213135-e1c09f13e2fe
[2020-09-08T03:07:08.729Z] go: downloading code.cloudfoundry.org/go-loggregator v7.4.0+incompatible
[2020-09-08T03:07:08.729Z] go: downloading code.cloudfoundry.org/go-diodes v0.0.0-20190809170250-f77fb823c7ee
[2020-09-08T03:07:08.729Z] go: downloading github.com/cloudfoundry-community/go-cfclient v0.0.0-20190808214049-35bcce23fc5f
[2020-09-08T03:07:08.729Z] go: downloading github.com/cloudfoundry/sonde-go v0.0.0-20171206171820-b33733203bb4
[2020-09-08T03:07:08.729Z] go: downloading code.cloudfoundry.org/gofileutils v0.0.0-20170111115228-4d0c80011a0f
[2020-09-08T03:07:08.729Z] go: downloading github.com/mailru/easyjson v0.7.1
[2020-09-08T03:07:08.729Z] go: downloading github.com/cloudfoundry/noaa v2.1.0+incompatible
[2020-09-08T03:07:08.729Z] go: downloading github.com/gorilla/websocket v1.4.1
[2020-09-08T03:07:08.729Z] go: downloading code.cloudfoundry.org/rfc5424 v0.0.0-20180905210152-236a6d29298a
[2020-09-08T03:07:08.729Z] go: downloading github.com/Masterminds/semver v1.4.2
[2020-09-08T03:07:08.729Z] go: downloading github.com/jmespath/go-jmespath v0.0.0-20180206201540-c2b33e8439af
[2020-09-08T03:07:08.729Z] 2020/09/08 03:06:31 Built /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-4169/src/github.com/elastic/apm-server/apm-server
[2020-09-08T03:07:08.729Z] --- PASS: TestAPMServer (138.38s)
[2020-09-08T03:07:08.729Z] === RUN   TestUnstartedAPMServer
[2020-09-08T03:07:08.729Z] --- PASS: TestUnstartedAPMServer (0.00s)
[2020-09-08T03:07:08.729Z] === RUN   TestExpvar
[2020-09-08T03:07:08.729Z] --- PASS: TestExpvar (0.25s)
[2020-09-08T03:07:08.729Z] PASS
[2020-09-08T03:07:08.729Z] ok  	github.com/elastic/apm-server/systemtest/apmservertest	138.643s
[2020-09-08T03:07:08.729Z] ?   	github.com/elastic/apm-server/systemtest/estest	[no test files]
[2020-09-08T03:07:08.729Z] + cleanup
[2020-09-08T03:07:08.729Z] + rm -rf /tmp/tmp.PSXZdx1tCr
[2020-09-08T03:07:08.729Z] + .ci/scripts/docker-get-logs.sh
[2020-09-08T03:07:09.849Z] Post stage
[2020-09-08T03:07:09.869Z] Running in /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-4169/src/github.com/elastic/apm-server
[2020-09-08T03:07:09.917Z] Archiving artifacts
[2020-09-08T03:07:10.274Z] Recording test results
[2020-09-08T03:07:10.994Z] [WARN] tar: pathPrefix parameter is deprecated.
[2020-09-08T03:07:11.353Z] + tar --version
[2020-09-08T03:07:11.719Z] + tar --exclude=system-tests-linux-files.tgz -czf system-tests-linux-files.tgz system-tests
[2020-09-08T03:07:11.720Z] tar: system-tests: Cannot stat: No such file or directory
[2020-09-08T03:07:11.720Z] tar: Exiting with failure status due to previous errors
[2020-09-08T03:07:11.750Z] [INFO] system-tests-linux-files.tgz was not compressed or archived : script returned exit code 2
[2020-09-08T03:07:12.424Z] Stage "Release" skipped due to when conditional
[2020-09-08T03:07:13.578Z] Running on worker-1225339 in /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-4169
[2020-09-08T03:07:13.665Z] [INFO] getVaultSecret: Getting secrets
[2020-09-08T03:07:13.758Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-09-08T03:07:16.026Z] + chmod 755 generate-build-data.sh
[2020-09-08T03:07:16.027Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-server/apm-server-mbp/PR-4169/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-server/apm-server-mbp/PR-4169/runs/1 UNSTABLE 1724459
[2020-09-08T03:07:16.027Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-server/apm-server-mbp/PR-4169/runs/1/steps/?limit=10000 -o steps-info.json
[2020-09-08T03:07:16.746Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-server/apm-server-mbp/PR-4169/runs/1/tests/?status=FAILED -o tests-errors.json

@axw axw merged commit c00585b into elastic:7.x Sep 8, 2020
@axw axw deleted the backport/7.x/pr-4127 branch September 8, 2020 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@axw