Skip to content

systemtest: fix API Key system test#4063

Merged
axw merged 1 commit intoelastic:masterfrom
axw:fix-apikey-systemtest
Aug 11, 2020
Merged

systemtest: fix API Key system test#4063
axw merged 1 commit intoelastic:masterfrom
axw:fix-apikey-systemtest

Conversation

@axw
Copy link
Copy Markdown
Member

@axw axw commented Aug 11, 2020

Ensure API Keys beginning with hyphens are not interpreted as CLI flags. See #3495

Fixes #4062

@axw
systemtest: fix API Key system test
36dfd8b 
Ensure API Keys beginning with hyphens are not
interpreted as CLI flags. See elastic#3495
@ghost
Copy link
Copy Markdown

ghost commented Aug 11, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #4063 opened]

  • Start Time: 2020-08-11T03:25:22.987+0000

  • Duration: 45 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 3214
Skipped 146
Total 3360

Steps errors

Expand to view the steps failures

  • Name: Compress

    • Description: tar --exclude=coverage-files.tgz -czf coverage-files.tgz coverage

    • Duration: 0 min 0 sec

    • Start Time: 2020-08-11T03:39:29.284+0000

    • log

  • Name: Compress

    • Description: tar --exclude=system-tests-linux-files.tgz -czf system-tests-linux-files.tgz system-tests

    • Duration: 0 min 0 sec

    • Start Time: 2020-08-11T04:03:25.678+0000

    • log

  • Name: Test Sync

    • Description: ./script/jenkins/sync.sh

    • Duration: 3 min 49 sec

    • Start Time: 2020-08-11T03:34:40.692+0000

    • log

@axw axw requested a review from a team August 11, 2020 06:00
simitt
simitt approved these changes Aug 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hope it didn't take too long (again) to figure that out; I should have left a comment when fixing in the python tests.

@axw
Copy link
Copy Markdown
Member Author

axw commented Aug 11, 2020

hope it didn't take too long (again) to figure that out; I should have left a comment when fixing in the python tests.

It didn't take long, no worries. The moment I saw a hyphen at the front of a failing API Key, I remembered your fix :)

@axw axw merged commit 9bd1b70 into elastic:master Aug 11, 2020
@axw axw deleted the fix-apikey-systemtest branch August 11, 2020 06:17
axw added a commit to axw/apm-server that referenced this pull request Sep 7, 2020
@axw
systemtest: fix API Key system test (elastic#4063)
ec1bc61 
Ensure API Keys beginning with hyphens are not
interpreted as CLI flags. See elastic#3495
@axw axw mentioned this pull request Sep 7, 2020
Merged
axw added a commit that referenced this pull request Sep 7, 2020
@axw
systemtest: fix API Key system test (#4063) (#4155)
92a3d99 
Ensure API Keys beginning with hyphens are not
interpreted as CLI flags. See #3495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@simitt simitt simitt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

systemtest: TestAPIKeyInvalidateID is flaky

2 participants

@axw @simitt