Fix flaky test for apikey info by id#3495
Merged
simitt merged 1 commit intoelastic:masterfrom Mar 17, 2020
Merged
Conversation
Ensure that IDs are treated as string values and not as flags when starting with a dash. fixes elastic#3298
graphaelli
approved these changes
Mar 17, 2020
simitt
added a commit
to simitt/apm-server
that referenced
this pull request
Mar 17, 2020
Ensure that IDs are treated as string values and not as flags when starting with a dash. fixes elastic#3298
simitt
added a commit
that referenced
this pull request
Mar 18, 2020
Contributor
|
oh my... :/ thanks for fixing |
axw
added a commit
to axw/apm-server
that referenced
this pull request
Aug 11, 2020
Ensure API Keys beginning with hyphens are not interpreted as CLI flags. See elastic#3495
axw
added a commit
that referenced
this pull request
Aug 11, 2020
Ensure API Keys beginning with hyphens are not interpreted as CLI flags. See #3495
axw
added a commit
to axw/apm-server
that referenced
this pull request
Sep 7, 2020
Ensure API Keys beginning with hyphens are not interpreted as CLI flags. See elastic#3495
axw
added a commit
that referenced
this pull request
Sep 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/summary
When passing an argument value that starts with a dash to a CLI tool it will be interpreted as a flag instead of a string value, e.g.
-xyzwould be interpreted as--xyz, when passed in as e.g.--id -xyzinstead of--id=-xyz.Instead of running
./apm-server apikey info --id -DB06HAB0_bchW-gz4ztit should be run as./apm-server apikey info --id="-DB06HAB0_bchW-gz4zt".This PR adapts the python system tests accordingly to avoid test flakyness wherever a value that might start with a dash is passed in to the apikey tests.
Checklist
- [ ] I have signed the Contributor License Agreement.- [ ] My code follows the style guidelines of this project (runmake check-fullfor static code checks and linting)- [ ] I have made corresponding changes to the documentation- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have updated CHANGELOG.asciidocHow to test these changes
Related issues
fixes #3298