Skip to content

Use service.version for Metadata.Service.Version when converting a Jaeger span#4061

Merged
axw merged 2 commits intoelastic:masterfrom
tobiasstadler:master
Aug 11, 2020
Merged

Use service.version for Metadata.Service.Version when converting a Jaeger span#4061
axw merged 2 commits intoelastic:masterfrom
tobiasstadler:master

Conversation

@tobiasstadler
Copy link
Copy Markdown
Contributor

@tobiasstadler tobiasstadler commented Aug 10, 2020

No description provided.

@ghost
Copy link
Copy Markdown

ghost commented Aug 10, 2020 •
edited by ghost
Loading

💔 Build Failed

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [axw commented: jenkins run the tests please]

  • Start Time: 2020-08-11T02:11:12.175+0000

  • Duration: 47 min 3 sec

Test stats 🧪

Test Results
Failed 0
Passed 3214
Skipped 146
Total 3360

Steps errors

Expand to view the steps failures

  • Name: Compress

    • Description: tar --exclude=coverage-files.tgz -czf coverage-files.tgz coverage

    • Duration: 0 min 0 sec

    • Start Time: 2020-08-11T02:26:18.372+0000

    • log

  • Name: Run Linux tests

    • Description: ./script/jenkins/linux-test.sh

    • Duration: 30 min 11 sec

    • Start Time: 2020-08-11T02:21:28.908+0000

    • log

  • Name: Compress

    • Description: tar --exclude=system-tests-linux-files.tgz -czf system-tests-linux-files.tgz system-tests

    • Duration: 0 min 0 sec

    • Start Time: 2020-08-11T02:51:42.159+0000

    • log

  • Name: Test Sync

    • Description: ./script/jenkins/sync.sh

    • Duration: 3 min 54 sec

    • Start Time: 2020-08-11T02:21:26.151+0000

    • log

Log output

Expand to view the last 100 lines of log output 

[2020-08-11T02:51:39.572Z] --- PASS: TestAPMServer (163.87s)
[2020-08-11T02:51:39.572Z] === RUN   TestUnstartedAPMServer
[2020-08-11T02:51:39.572Z] --- PASS: TestUnstartedAPMServer (0.00s)
[2020-08-11T02:51:39.572Z] === RUN   TestExpvar
[2020-08-11T02:51:39.572Z] --- PASS: TestExpvar (0.30s)
[2020-08-11T02:51:39.572Z] PASS
[2020-08-11T02:51:39.572Z] ok  	github.com/elastic/apm-server/systemtest/apmservertest	164.194s
[2020-08-11T02:51:39.572Z] ?   	github.com/elastic/apm-server/systemtest/estest	[no test files]
[2020-08-11T02:51:39.572Z] FAIL
[2020-08-11T02:51:39.572Z] + cleanup
[2020-08-11T02:51:39.572Z] + rm -rf /tmp/tmp.SNb1OwgPYu
[2020-08-11T02:51:39.572Z] + .ci/scripts/docker-get-logs.sh
[2020-08-11T02:51:40.603Z] Post stage
[2020-08-11T02:51:40.613Z] Running in /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-4061/src/github.com/elastic/apm-server
[2020-08-11T02:51:40.637Z] Archiving artifacts
[2020-08-11T02:51:41.007Z] Recording test results
[2020-08-11T02:51:41.795Z] [WARN] tar: pathPrefix parameter is deprecated.
[2020-08-11T02:51:42.129Z] + tar --version
[2020-08-11T02:51:42.448Z] + tar --exclude=system-tests-linux-files.tgz -czf system-tests-linux-files.tgz system-tests
[2020-08-11T02:51:42.449Z] tar: system-tests: Cannot stat: No such file or directory
[2020-08-11T02:51:42.449Z] tar: Exiting with failure status due to previous errors
[2020-08-11T02:51:42.462Z] [INFO] system-tests-linux-files.tgz was not compressed or archived : script returned exit code 2
[2020-08-11T02:51:42.603Z] Failed in branch System and Environment Tests
[2020-08-11T02:52:08.808Z] [INFO] getVaultSecret: Getting secrets
[2020-08-11T02:52:08.880Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-08-11T02:52:10.012Z] + set +x
[2020-08-11T02:52:10.586Z] Login Succeeded
[2020-08-11T02:52:11.301Z] + ./script/jenkins/package-docker-snapshot.sh 2644d5a923073923cbe91059c9290932a0ceb41c docker.elastic.co/observability-ci/apm-server
[2020-08-11T02:52:11.301Z] INFO: Build docker images
[2020-08-11T02:52:11.564Z] ./build/linux/mage package
[2020-08-11T02:52:11.564Z] 2020/08/11 02:52:11 exec: go list -m
[2020-08-11T02:52:12.143Z] >> Building apm-server.yml for linux/amd64
[2020-08-11T02:52:12.144Z] >> Building apm-server.docker.yml for linux/amd64
[2020-08-11T02:52:12.719Z] Generated fields.yml for apm-server to /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-4061/src/github.com/elastic/apm-server/build/fields/fields.yml
[2020-08-11T02:52:14.114Z] Generated fields.yml for apm-server to /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-4061/src/github.com/elastic/apm-server/build/fields/fields.all.yml
[2020-08-11T02:52:18.341Z] >> golangCrossBuild: Building for linux/amd64
[2020-08-11T02:52:18.341Z] >> buildGoDaemon: Building for linux/amd64
[2020-08-11T02:52:18.341Z] >> golangCrossBuild: Building for linux/amd64
[2020-08-11T02:52:19.733Z] >> Building using: cmd='build/mage-linux-amd64 buildGoDaemon', env=[CC=gcc, CXX=g++, GOARCH=amd64, GOARM=, GOOS=linux, PLATFORM_ID=linux-amd64]
[2020-08-11T02:52:19.733Z] >> Building using: cmd='../../build/mage-linux-amd64 golangCrossBuild', env=[CC=gcc, CXX=g++, GOARCH=amd64, GOARM=, GOOS=linux, PLATFORM_ID=linux-amd64]
[2020-08-11T02:52:19.733Z] 2020/08/11 02:52:19 exec: go list -m
[2020-08-11T02:52:19.733Z] 2020/08/11 02:52:19 exec: go list -m
[2020-08-11T02:52:19.733Z] >> Building using: cmd='build/mage-linux-amd64 golangCrossBuild', env=[CC=gcc, CXX=g++, GOARCH=amd64, GOARM=, GOOS=linux, PLATFORM_ID=linux-amd64]
[2020-08-11T02:52:19.733Z] 2020/08/11 02:52:19 exec: go list -m
[2020-08-11T02:55:26.500Z] >> package: Building apm-server type=docker for platform=linux/amd64
[2020-08-11T02:55:26.500Z] >> package: Building apm-server-oss type=docker for platform=linux/amd64
[2020-08-11T02:55:26.500Z] >> package: Building apm-server-oss type=tar.gz for platform=linux/amd64
[2020-08-11T02:55:26.500Z] >> package: Building apm-server-oss type=deb for platform=linux/amd64
[2020-08-11T02:55:26.500Z] >> package: Building apm-server-oss type=rpm for platform=linux/amd64
[2020-08-11T02:55:26.500Z] Doing `require 'backports'` is deprecated and will not load any backport in the next major release.
[2020-08-11T02:55:26.500Z] Require just the needed backports instead, or 'backports/latest'.
[2020-08-11T02:55:30.744Z] Doing `require 'backports'` is deprecated and will not load any backport in the next major release.
[2020-08-11T02:55:30.744Z] Require just the needed backports instead, or 'backports/latest'.
[2020-08-11T02:55:32.148Z] >> package: Building apm-server type=rpm for platform=linux/amd64
[2020-08-11T02:55:47.113Z] Doing `require 'backports'` is deprecated and will not load any backport in the next major release.
[2020-08-11T02:55:47.113Z] Require just the needed backports instead, or 'backports/latest'.
[2020-08-11T02:55:55.279Z] >> package: Building apm-server type=deb for platform=linux/amd64
[2020-08-11T02:56:07.546Z] Doing `require 'backports'` is deprecated and will not load any backport in the next major release.
[2020-08-11T02:56:07.546Z] Require just the needed backports instead, or 'backports/latest'.
[2020-08-11T02:56:14.157Z] >> package: Building apm-server type=tar.gz for platform=linux/amd64
[2020-08-11T02:56:20.768Z] >> Testing package contents
[2020-08-11T02:56:42.752Z] package ran for 4m30.97322355s
[2020-08-11T02:56:42.752Z] INFO: Get the just built docker image
[2020-08-11T02:56:43.016Z] INFO: Retag docker image (docker.elastic.co/apm/apm-server:8.0.0-SNAPSHOT)
[2020-08-11T02:56:43.016Z] INFO: Push docker image (docker.elastic.co/observability-ci/apm-server:2644d5a923073923cbe91059c9290932a0ceb41c)
[2020-08-11T02:56:43.016Z] The push refers to repository [docker.elastic.co/observability-ci/apm-server]
[2020-08-11T02:56:43.280Z] 1ea377cdeee5: Preparing
[2020-08-11T02:56:43.280Z] fa46b2894b69: Preparing
[2020-08-11T02:56:43.280Z] 20c7400ea0bb: Preparing
[2020-08-11T02:56:43.280Z] b7b657560ac3: Preparing
[2020-08-11T02:56:43.280Z] ebaf389dd15a: Preparing
[2020-08-11T02:56:43.280Z] 122afdf5ce4f: Preparing
[2020-08-11T02:56:43.280Z] 333cbc7df871: Preparing
[2020-08-11T02:56:43.280Z] 613be09ab3c0: Preparing
[2020-08-11T02:56:43.280Z] 333cbc7df871: Waiting
[2020-08-11T02:56:43.280Z] 122afdf5ce4f: Waiting
[2020-08-11T02:56:43.280Z] 613be09ab3c0: Waiting
[2020-08-11T02:56:45.207Z] 20c7400ea0bb: Pushed
[2020-08-11T02:56:45.207Z] b7b657560ac3: Pushed
[2020-08-11T02:56:45.207Z] 1ea377cdeee5: Pushed
[2020-08-11T02:56:45.207Z] ebaf389dd15a: Pushed
[2020-08-11T02:56:49.440Z] 333cbc7df871: Pushed
[2020-08-11T02:56:53.658Z] fa46b2894b69: Pushed
[2020-08-11T02:56:55.577Z] 122afdf5ce4f: Pushed
[2020-08-11T02:57:02.174Z] 613be09ab3c0: Pushed
[2020-08-11T02:57:03.563Z] 2644d5a923073923cbe91059c9290932a0ceb41c: digest: sha256:5bcc0716f02acb46da0e87e7bcb1e0f65528a2c54f44bcfb8830e064d5f9a84d size: 1993
[2020-08-11T02:57:03.615Z] $ docker stop --time=1 ae0c7e0405659e50aecbadbb0578e985cc5b1b895e5d49becc38c01a53e09105
[2020-08-11T02:57:04.978Z] $ docker rm -f ae0c7e0405659e50aecbadbb0578e985cc5b1b895e5d49becc38c01a53e09105
[2020-08-11T02:57:06.400Z] Stage "Publish" skipped due to when conditional
[2020-08-11T02:58:10.235Z] [INFO] For detailed information see: https://apm-ci.elastic.co/job/apm-integration-tests-selector-mbp/job/master/9842/display/redirect
[2020-08-11T02:58:12.465Z] Copied 50 artifacts from "APM Integration Test MBP Selector » master" build number 9842
[2020-08-11T02:58:13.504Z] Post stage
[2020-08-11T02:58:13.515Z] Recording test results
[2020-08-11T02:58:14.625Z] Running on Jenkins in /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-4061
[2020-08-11T02:58:14.685Z] [INFO] getVaultSecret: Getting secrets
[2020-08-11T02:58:14.749Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-08-11T02:58:15.456Z] + chmod 755 generate-build-data.sh
[2020-08-11T02:58:15.456Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-server/apm-server-mbp/PR-4061/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-server/apm-server-mbp/PR-4061/runs/3 FAILURE 2823023
[2020-08-11T02:58:16.007Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-server/apm-server-mbp/PR-4061/runs/3/steps/?limit=10000 -o steps-info.json
[2020-08-11T02:58:16.558Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-server/apm-server-mbp/PR-4061/runs/3/tests/?status=FAILED -o tests-errors.json

axw
axw approved these changes Aug 11, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@axw
Copy link
Copy Markdown
Member

axw commented Aug 11, 2020

jenkins run the tests please

@axw
Copy link
Copy Markdown
Member

axw commented Aug 11, 2020

Unrelated test failure, opened #4062

@axw axw merged commit 0458a0e into elastic:master Aug 11, 2020
@axw axw added the v7.10.0 label Aug 11, 2020
@simitt simitt self-assigned this Oct 14, 2020
simitt pushed a commit to simitt/apm-server that referenced this pull request Oct 14, 2020
@tobiasstadler @simitt
Use service.version for Metadata.Service.Version when converting a Ja…
0313927 
…eger span (elastic#4061)

* Use service.version for Metadata.Service.Version when converting a Jaeger span

* Added elastic#40 to changelog
@simitt simitt mentioned this pull request Oct 14, 2020
Merged
simitt pushed a commit to simitt/apm-server that referenced this pull request Oct 14, 2020
@tobiasstadler @simitt
Use service.version for Metadata.Service.Version when converting a Ja…
ed0fb9f 
…eger span (elastic#4061)

* Use service.version for Metadata.Service.Version when converting a Jaeger span

* Added elastic#40 to changelog
This was referenced Oct 14, 2020
Merged
Closed
simitt added a commit that referenced this pull request Oct 14, 2020
@simitt @tobiasstadler
Use service.version for Metadata.Service.Version when converting a Ja…
d66f285 
…eger span (#4061) (#4318)

* Use service.version for Metadata.Service.Version when converting a Jaeger span

* Added #40 to changelog

Co-authored-by: Tobias Stadler <ts.stadler@gmx.de>
simitt added a commit that referenced this pull request Oct 14, 2020
@simitt @tobiasstadler
Use service.version for Metadata.Service.Version when converting a Ja…
774ecbf 
…eger span (#4061) (#4317)

* Use service.version for Metadata.Service.Version when converting a Jaeger span

* Added #40 to changelog

Co-authored-by: Tobias Stadler <ts.stadler@gmx.de>
@simitt
Copy link
Copy Markdown
Contributor

simitt commented Oct 14, 2020

open to test - needed backport for 7.10

@simitt
Copy link
Copy Markdown
Contributor

simitt commented Oct 15, 2020

tested with BC2 - works with span specific tags;
for process specific tags there's a follow up issue open #4319.

This was referenced Sep 6, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@axw axw axw approved these changes

Assignees

@simitt simitt

Labels

test-plan test-plan-ok v7.10.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tobiasstadler @axw @simitt @jalvz