Skip to content

[7.x] Use service.version for Metadata.Service.Version when converting a Jaeger span (#4061)#4317

Merged
simitt merged 1 commit intoelastic:7.xfrom
simitt:backport/7.x/pr-4061
Oct 14, 2020
Merged

[7.x] Use service.version for Metadata.Service.Version when converting a Jaeger span (#4061)#4317
simitt merged 1 commit intoelastic:7.xfrom
simitt:backport/7.x/pr-4061

Conversation

@simitt
Copy link
Copy Markdown
Contributor

@simitt simitt commented Oct 14, 2020

Backports the following commits to 7.x:

…eger span (elastic#4061)

* Use service.version for Metadata.Service.Version when converting a Jaeger span

* Added elastic#40 to changelog
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #4317 into 7.x will increase coverage by 4.51%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              7.x    #4317      +/-   ##
==========================================
+ Coverage   75.79%   80.31%   +4.51%     
==========================================
  Files          64      158      +94     
  Lines        3669     8647    +4978     
==========================================
+ Hits         2781     6945    +4164     
- Misses        888     1702     +814     
Impacted Files Coverage Δ
agentcfg/cache.go 85.71% <ø> (ø)
agentcfg/fetch.go 87.87% <ø> (ø)
agentcfg/model.go 100.00% <ø> (ø)
beater/api/asset/sourcemap/handler.go 88.00% <ø> (ø)
beater/api/config/agent/handler.go 94.95% <ø> (ø)
beater/api/expvar.go 0.00% <ø> (ø)
beater/api/intake/handler.go 97.26% <ø> (ø)
beater/api/mux.go 90.58% <ø> (ø)
beater/api/profile/handler.go 89.62% <ø> (ø)
beater/api/ratelimit/store.go 91.30% <ø> (ø)
... and 190 more

@ghost
Copy link
Copy Markdown

ghost commented Oct 14, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #4317 opened]

  • Start Time: 2020-10-14T10:01:30.064+0000

  • Duration: 29 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 4038
Skipped 142
Total 4180

Steps errors 2

Expand to view the steps failures

  • Name: Compress

    • Description: tar --exclude=coverage-files.tgz -czf coverage-files.tgz coverage

    • Duration: 0 min 0 sec

    • Start Time: 2020-10-14T10:16:46.398+0000

    • log

  • Name: Compress

    • Description: tar --exclude=system-tests-linux-files.tgz -czf system-tests-linux-files.tgz system-tests

    • Duration: 0 min 0 sec

    • Start Time: 2020-10-14T10:30:17.264+0000

    • log

@simitt simitt merged commit 774ecbf into elastic:7.x Oct 14, 2020
@simitt simitt deleted the backport/7.x/pr-4061 branch October 19, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants