Skip to content

[7.x] Cloud metadata (#3729)#3743

Merged
axw merged 1 commit intoelastic:7.xfrom
axw:backport/7.x/pr-3729
May 5, 2020
Merged

[7.x] Cloud metadata (#3729)#3743
axw merged 1 commit intoelastic:7.xfrom
axw:backport/7.x/pr-3729

Conversation

@axw
Copy link
Copy Markdown
Member

@axw axw commented May 5, 2020

Backports the following commits to 7.x:

* model: add Cloud type, Metadata.Cloud field

* docs/spec: add cloud to metadata schema

* modeldecoder: decode Cloud metadata

* Update integration tests

- Add cloud metadata to testdata
- Add cloud fields to _meta/fields.common.yml for tests :(
- Update approvals docs
- Update package_tests (cargo-culted)

* Add changelog entry

* _meta: add 'overwrite: true' to duplicated fields
@axw axw added the backport label May 5, 2020
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3743 into 7.x will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              7.x    #3743      +/-   ##
==========================================
+ Coverage   79.75%   79.87%   +0.12%     
==========================================
  Files         134      136       +2     
  Lines        6110     6147      +37     
==========================================
+ Hits         4873     4910      +37     
  Misses       1237     1237              
Impacted Files Coverage Δ
model/cloud.go 100.00% <100.00%> (ø)
model/metadata.go 100.00% <100.00%> (ø)
model/modeldecoder/cloud.go 100.00% <100.00%> (ø)
model/modeldecoder/metadata.go 77.27% <100.00%> (+1.08%) ⬆️

@ghost
Copy link
Copy Markdown

ghost commented May 5, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 3008
Skipped 142
Total 3150

Steps errors

Expand to view the steps failures

  • Name: Test Sync
    • Description: ./script/jenkins/sync.sh

    • Result: FAILURE

    • Duration: 3 min 40 sec<

    • Start Time: 2020-05-05T05:07:36.344+0000

@axw axw merged commit 42d9985 into elastic:7.x May 5, 2020
@axw axw deleted the backport/7.x/pr-3729 branch May 5, 2020 05:33
@simitt
Copy link
Copy Markdown
Contributor

simitt commented May 12, 2020

Tested with some constructed data, until the agents support this.

@simitt simitt self-assigned this May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants