Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
Member
Author
|
jenkins run the tests please |
- Add cloud metadata to testdata - Add cloud fields to _meta/fields.common.yml for tests :( - Update approvals docs - Update package_tests (cargo-culted)
jalvz
approved these changes
May 4, 2020
graphaelli
reviewed
May 4, 2020
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
axw
added a commit
to axw/apm-server
that referenced
this pull request
May 5, 2020
* model: add Cloud type, Metadata.Cloud field * docs/spec: add cloud to metadata schema * modeldecoder: decode Cloud metadata * Update integration tests - Add cloud metadata to testdata - Add cloud fields to _meta/fields.common.yml for tests :( - Update approvals docs - Update package_tests (cargo-culted) * Add changelog entry * _meta: add 'overwrite: true' to duplicated fields
axw
added a commit
that referenced
this pull request
May 5, 2020
* model: add Cloud type, Metadata.Cloud field * docs/spec: add cloud to metadata schema * modeldecoder: decode Cloud metadata * Update integration tests - Add cloud metadata to testdata - Add cloud fields to _meta/fields.common.yml for tests :( - Update approvals docs - Update package_tests (cargo-culted) * Add changelog entry * _meta: add 'overwrite: true' to duplicated fields
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
May 7, 2020
This file was added to the APM Server repo in: elastic/apm-server#3729
watson
added a commit
to elastic/apm-agent-nodejs
that referenced
this pull request
May 7, 2020
This file was added to the APM Server repo in: elastic/apm-server#3729
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
May 7, 2020
This file was added to the APM Server repo in: elastic/apm-server#3729
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
May 11, 2020
This file was added to the APM Server repo in: elastic/apm-server#3729
watson
added a commit
to elastic/apm-agent-nodejs
that referenced
this pull request
May 11, 2020
Backport two commits to fix the tests in 2.x: * test: fix APM Server cert test to work with 13.9.0+ (c3c119b) * test: add missing APM Server API Scheme file cloud.json (#1738) This file was added to the APM Server repo in: elastic/apm-server#3729
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Add
cloudmetadata to Elastic APM event schema. See elastic/apm#256 for rationale.Checklist
make check-fullfor static code checks and linting)- [ ] I have made corresponding changes to the documentationHow to test these changes
Related issues
Closes #3660