strip trailing slashes from kibana host configuration#3277
Merged
graphaelli merged 11 commits intoelastic:masterfrom Feb 5, 2020
Merged
strip trailing slashes from kibana host configuration#3277graphaelli merged 11 commits intoelastic:masterfrom
graphaelli merged 11 commits intoelastic:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3277 +/- ##
=========================================
Coverage ? 79.32%
=========================================
Files ? 107
Lines ? 5624
Branches ? 0
=========================================
Hits ? 4461
Misses ? 1163
Partials ? 0
|
axw
requested changes
Feb 4, 2020
per review feedback
Codecov Report
@@ Coverage Diff @@
## master #3277 +/- ##
=======================================
Coverage 79.33% 79.34%
=======================================
Files 107 107
Lines 5600 5621 +21
=======================================
+ Hits 4443 4460 +17
- Misses 1157 1161 +4 |
axw
approved these changes
Feb 4, 2020
Member
axw
left a comment
There was a problem hiding this comment.
LGTM, with a few small suggestions/requests
Co-Authored-By: Andrew Wilkins <axwalk@gmail.com>
rather than converting between common.Config and back
Member
Author
|
holding off on merging this for a day or two to see if we can get the upstream changes into beats first |
graphaelli
added a commit
to graphaelli/apm-server
that referenced
this pull request
Feb 5, 2020
Co-Authored-By: Andrew Wilkins <axwalk@gmail.com>
graphaelli
added a commit
that referenced
this pull request
Feb 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2647
Can remove some duplication / risk of getting out of sync with beats framework if elastic/beats#16042 is accepted