Merged
Conversation
v1v
commented
May 7, 2024
| default: | ||
| kind: github | ||
| spec: | ||
| user: '{{ requiredEnv "GIT_USER" }}' |
Member
Author
There was a problem hiding this comment.
reakaleek
approved these changes
May 7, 2024
endorama
approved these changes
May 8, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 8, 2024
(cherry picked from commit aa75f30)
2 tasks
mergify bot
pushed a commit
that referenced
this pull request
May 8, 2024
(cherry picked from commit aa75f30)
2 tasks
mergify bot
pushed a commit
that referenced
this pull request
May 8, 2024
(cherry picked from commit aa75f30)
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Leverage updatecli/updatecli#1914 and support commit signature verifications
Checklist
For functional changes, consider:
How to test these changes
I tested it in a playground:
And also in my fork, for such I used this set of changes and tweaked a bit my main branch,
Then https://github.com/v1v/apm-server/pull/43/commits was created
Related issues
Then if it works as expected in the CI, changes will be applied to the remaining updatecli manifests