Skip to content

[7.17] updatecli: verify commits (backport #13103)#13104

Merged
mergify[bot] merged 1 commit into7.17from
mergify/bp/7.17/pr-13103
May 8, 2024
Merged

[7.17] updatecli: verify commits (backport #13103)#13104
mergify[bot] merged 1 commit into7.17from
mergify/bp/7.17/pr-13103

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented May 8, 2024

Motivation/summary

Leverage updatecli/updatecli#1914 and support commit signature verifications

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

I tested it in a playground:

And also in my fork, for such I used this set of changes and tweaked a bit my main branch,

Then https://github.com/v1v/apm-server/pull/43/commits was created

Related issues

Then if it works as expected in the CI, changes will be applied to the remaining updatecli manifests


This is an automatic backport of pull request #13103 done by Mergify.

(cherry picked from commit aa75f30)
@mergify mergify bot added the backport label May 8, 2024
@mergify mergify bot assigned v1v May 8, 2024
@mergify mergify bot merged commit 5b885bc into 7.17 May 8, 2024
@mergify mergify bot deleted the mergify/bp/7.17/pr-13103 branch May 8, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant