Skip to content

refactor: replace globby with faster alternative#1158

Merged
sxzz merged 2 commits intoegoist:devfrom
SuperchupuDev:refactor/globby-but-fast
Jul 19, 2024
Merged

refactor: replace globby with faster alternative#1158
sxzz merged 2 commits intoegoist:devfrom
SuperchupuDev:refactor/globby-but-fast

Conversation

@SuperchupuDev
Copy link
Contributor

@SuperchupuDev SuperchupuDev commented Jul 17, 2024 •
edited
Loading

globby has a count of 23 subdependencies, which is far from ideal for something as simple as globbing. This PR switches to a lighter and faster alternative using fdir and picomatch. They have both a total of zero (0) subdependencies, making this not just a faster approach, but also one that's way lighter.

This makes tsup go from 102 subdependencies down to just 88.

Note: The patterns at

tsup/src/utils.ts

Lines 69 to 77 in 57a372b

const matchPatterns: string[] = []
const ignorePatterns: string[] = []
for (const pattern of patterns) {
if (pattern.startsWith('!') && pattern[1] !== '(') {
ignorePatterns.push(pattern.slice(1))
} else {
matchPatterns.push(pattern)
}
}
are filtered this way to properly match what globby (or more specifically, fast-glob which is used by globby) does. It has some behavior around negated patterns no other globbing library has.

Relevant prior work: dotenvx/dotenvx#278

@codesandbox
Copy link

codesandbox bot commented Jul 17, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@vercel
Copy link

vercel bot commented Jul 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tsup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 2:53pm

@SuperchupuDev
Copy link
Contributor Author

SuperchupuDev commented Jul 17, 2024 •
edited
Loading

tests are failing on windows but not on linux...weird

@SuperchupuDev SuperchupuDev force-pushed the refactor/globby-but-fast branch from a4e4896 to e5ea6d3 Compare July 17, 2024 17:02
@SuperchupuDev SuperchupuDev force-pushed the refactor/globby-but-fast branch from e5ea6d3 to b55de45 Compare July 17, 2024 17:06
@SuperchupuDev SuperchupuDev force-pushed the refactor/globby-but-fast branch from b55de45 to 3492fbd Compare July 17, 2024 17:08
@SuperchupuDev SuperchupuDev force-pushed the refactor/globby-but-fast branch from 3492fbd to 22fcc5c Compare July 17, 2024 17:11
@SuperchupuDev SuperchupuDev force-pushed the refactor/globby-but-fast branch from 22fcc5c to 3e610e7 Compare July 17, 2024 17:21
@sxzz
Copy link
Collaborator

sxzz commented Jul 19, 2024 •
edited
Loading

I think we can use fdir and picomatch to create a new library for lightweight glob, enhancing maintainability.

@SuperchupuDev
Copy link
Contributor Author

SuperchupuDev commented Jul 19, 2024 •
edited
Loading

the implementation here isnt big really, there's a pr in fdir to add a glob function method though (requiring a matcher function) that maybe could be used in the future. i dont really see a need of making it a lib if sometimes fdir is called in a way picomatch (therefore globbing) isnt even needed

@sxzz sxzz force-pushed the refactor/globby-but-fast branch from 3e610e7 to ff3acc0 Compare July 19, 2024 14:53
@sxzz sxzz merged commit 0f0b4b2 into egoist:dev Jul 19, 2024
@SuperchupuDev SuperchupuDev deleted the refactor/globby-but-fast branch July 19, 2024 15:05
@jfmengels jfmengels mentioned this pull request Jul 19, 2024
Open
10 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2024

🎉 This issue has been resolved in version 8.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lenovouser
Copy link

lenovouser commented Jul 21, 2024

I am getting this now after upgrading to 8.2.1

Screenshot 2024-07-21 at 11 47 51

@SuperchupuDev
Copy link
Contributor Author

SuperchupuDev commented Jul 21, 2024 •
edited
Loading

i am aware, when conflicts were solved, it looks like picomatch was updated to v4 which fdir's package.json doesn't allow. to fix this tsup must downgrade to picomatch v3 or fdir must release a new version which contains a fix i submitted a few days ago thecodrr/fdir#101

@SuperchupuDev SuperchupuDev mentioned this pull request Jul 21, 2024
Closed
@SuperchupuDev SuperchupuDev mentioned this pull request Jul 21, 2024
Closed
egoist added a commit that referenced this pull request Jul 22, 2024
@egoist
fix: Revert "refactor: replace globby with faster alternative (#1158)"
2de6dd5 
This reverts commit 0f0b4b2.
@nerdy-tech-com-gitub nerdy-tech-com-gitub mentioned this pull request Oct 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sxzz sxzz sxzz approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SuperchupuDev @sxzz @lenovouser