replace glob with faster approach#278
Merged
motdotla merged 1 commit intodotenvx:mainfrom Jun 30, 2024
Merged
Conversation
Contributor
Author
|
created branch from an outdated one, trying to fix... |
6d2b76f to
0465a6e
Compare
0465a6e to
46626ed
Compare
Contributor
Author
|
fixed :) |
Contributor
|
better sorting than glob as well. thanks! |
This was referenced Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaces the usage of
globwithfdirandpicomatch.globuses 27 whole subdependencies, making it far from ideal.fdirandpicomatchhave both a total of zero (0) subdependencies, making this not just a faster approach, but also one that's way lighter. this makes dotenvx go from 150 subdependencies down to127131.the testing arrays only changed in order, they contain exactly the same elements, it looks like
fdirsorts them slightly different thanglob.i couldn't have done this without the help of the e18e server, props to everyone involved for fighting for a more optimized js future :-)