feat: Add information to run via proxy for usb/onvif services#1184
Merged
ajcasagrande merged 4 commits intoedgexfoundry:mainfrom Aug 15, 2023
Merged
Conversation
Signed-off-by: Sean O'Hair <sean.ohair@intel.com>
vyshali-chitikeshi
left a comment
There was a problem hiding this comment.
Able to deploy onvif and usb services with proxy using docker based on instructions provided in documentation.
As per our discussion, please make below changes for both Onvif and USB setup guides.
- Add (optional) for proxy setup section
- add note stating that, Device where user deploying Onviv and/or usb needs to be configured to use proxy
- Remove warning/limitation for onvif camera auto discovery, and add note stating auto discovery needs to be configured with proper network interface and auto discovery subnets
Signed-off-by: Sean O'Hair <sean.ohair@intel.com>
vyshali-chitikeshi
left a comment
There was a problem hiding this comment.
In onvif setup guide, please change below text
from
"Automated discovery of ONVIF device requires using provided script to get proper discovery subnets and proper network interface."
to
"Automated discovery of ONVIF device requires updating proper discovery subnets and proper network interface in ONVIF configuraton.yaml or setting up edgex environment variables".
ajcasagrande
requested changes
Aug 15, 2023
docs_src/microservices/device/supported/device-onvif-camera/Walkthrough/setup.md
Outdated
Show resolved
Hide resolved
docs_src/microservices/device/supported/device-onvif-camera/Walkthrough/setup.md
Outdated
Show resolved
Hide resolved
docs_src/microservices/device/supported/device-onvif-camera/Walkthrough/setup.md
Outdated
Show resolved
Hide resolved
docs_src/microservices/device/supported/device-onvif-camera/Walkthrough/setup.md
Show resolved
Hide resolved
docs_src/microservices/device/supported/device-onvif-camera/Walkthrough/setup.md
Outdated
Show resolved
Hide resolved
docs_src/microservices/device/supported/device-usb-camera/walkthrough/setup.md
Show resolved
Hide resolved
Signed-off-by: Sean O'Hair <sean.ohair@intel.com>
marcpfuller
approved these changes
Aug 15, 2023
|
LGTM |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1157
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-docs/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements: