Skip to content

[1.9.x] Increase recv buffer on PubSubAsNonReliableData300kb#902

Merged
MiguelCompany merged 1 commit into1.9.xfrom
bugfix/fragments_test_buffer_size/1.9.x
Nov 29, 2019
Merged

[1.9.x] Increase recv buffer on PubSubAsNonReliableData300kb#902
MiguelCompany merged 1 commit into1.9.xfrom
bugfix/fragments_test_buffer_size/1.9.x

Conversation

@IkerLuengo
Copy link
Copy Markdown
Contributor

This PR increases the reception buffer on the test.

The test is failing a lot after allowing fragment delivery on synchronized transport, because we are now sending 5 packets per change, each packet with max size, at fast rate, and the receiving buffer gets full.

Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@richiware
Copy link
Copy Markdown
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status
  • Performance Build Status

@MiguelCompany
Copy link
Copy Markdown
Member

Failing tests not related

@MiguelCompany MiguelCompany merged commit 412ba19 into 1.9.x Nov 29, 2019
@MiguelCompany MiguelCompany deleted the bugfix/fragments_test_buffer_size/1.9.x branch November 29, 2019 10:16
IkerLuengo added a commit that referenced this pull request Dec 13, 2019
This is a port of PR #898 and PR #902 into master
IkerLuengo added a commit that referenced this pull request Feb 25, 2020
MiguelCompany pushed a commit that referenced this pull request Feb 25, 2020
* Refs 6830. Sending fragments on sync writers

This is a port of #898 from 1.9.x

* ref [#6830] Modify tests sending fragments over sync

* ref [#6830] statelessWriter to send fragments when sync

* ref[#6830] statefulWriter to send fragments when sync

* Refs 6963. Increase recv buffer on PubSubAsNonReliableData300kb

This is a port of #902 from 1.9.X

* Refs 6830. log error if large message and separate sending

This casuistry is not currently supported

* Refs 6830. review suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants