Skip to content

Sending fragments on sync writers <master> [6955]#1029

Merged
MiguelCompany merged 4 commits intomasterfrom
feature/fragments_on_sync_writers_master
Feb 25, 2020
Merged

Sending fragments on sync writers <master> [6955]#1029
MiguelCompany merged 4 commits intomasterfrom
feature/fragments_on_sync_writers_master

Conversation

@IkerLuengo
Copy link
Copy Markdown
Contributor

@IkerLuengo IkerLuengo commented Feb 24, 2020 •
edited by MiguelCompany
Loading

This is a port of #898 and #902 from 1.9.x

@richiware
Copy link
Copy Markdown
Member

richiware commented Feb 24, 2020

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

MiguelCompany
MiguelCompany requested changes Feb 25, 2020
View reviewed changes
MiguelCompany
MiguelCompany previously approved these changes Feb 25, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware
Copy link
Copy Markdown
Member

richiware commented Feb 25, 2020

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@IkerLuengo
Refs 6830. Sending fragments on sync writers
029ca3f 
This is a port of #898 from 1.9.x

* ref [#6830] Modify tests sending fragments over sync

* ref [#6830] statelessWriter to send fragments when sync

* ref[#6830] statefulWriter to send fragments when sync
@IkerLuengo
Refs 6963. Increase recv buffer on PubSubAsNonReliableData300kb
e7d4dfd 
This is a port of #902 from 1.9.X
@IkerLuengo
Refs 6830. log error if large message and separate sending
8f066a0 
This casuistry is not currently supported
@IkerLuengo
Refs 6830. review suggestions
1ee81fc
@IkerLuengo IkerLuengo force-pushed the feature/fragments_on_sync_writers_master branch from 9283cdd to 1ee81fc Compare February 25, 2020 12:11
MiguelCompany
MiguelCompany approved these changes Feb 25, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware
Copy link
Copy Markdown
Member

richiware commented Feb 25, 2020 •
edited by MiguelCompany
Loading

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status
    • Failed test is not related as it does not send fragments.

@MiguelCompany MiguelCompany merged commit e1ffdc3 into master Feb 25, 2020
@MiguelCompany MiguelCompany deleted the feature/fragments_on_sync_writers_master branch February 25, 2020 13:54
@EduPonz EduPonz mentioned this pull request Mar 16, 2020
Merged
@MiguelCompany MiguelCompany mentioned this pull request Mar 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@IkerLuengo @richiware @MiguelCompany