[24101] Fix build in GCC 15 by raulojeda22 · Pull Request #6263 · eProsima/Fast-DDS

raulojeda22 · 2026-01-20T10:14:10Z

Description

Fix compilation with GCC 15 by adding missing #include <cstdint> to SharedSecretHandle.h.
GCC 15 is stricter about implicit includes, and uint8_t requires an explicit #include <cstdint>. Without this include, compilation fails with errors like:

error: 'uint8_t' was not declared in this scope

Additionally, GCC 15 shows a false positive warning in sqlite3.c:

warning: ‘strlen’ reading 1 or more bytes from a region of size 0 [-Wstringop-overread]
35253 |   return 0x3fffffff & (int)strlen(z);

Which is fixed in this PR by changing the if statement to a ternary operator.

@Mergifyio backport 3.4.x 3.3.x 3.2.x 2.14.x

Fixes #6254

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Raül <raulojeda@eprosima.com>

cferreiragonz

Add also CMake flags into this line to build Fast DDS with Security and Statistics features in the alternative build workflow

Signed-off-by: Raül <raulojeda@eprosima.com>

.github/workflows/docker/ubuntu/alternative_builds/fastdds_gcc_latest.Dockerfile

src/cpp/rtps/security/common/SharedSecretHandle.h

Signed-off-by: Raül <raulojeda@eprosima.com>

mergify · 2026-01-20T20:23:43Z

🧪 CI Insights

Here's what we observed from your CI run for 37e96d5.

❌ Job Failures

Pipeline	Job	Health on `master`	Retries	🔍 CI Insights	📄 Logs
`Fast DDS MacOS CI`	`mac-ci / fastdds_test ()`		`0`	View	View

✅ Passed Jobs With Interesting Signals

Pipeline	Job	Signal	Health on `master`	Retries	🔍 CI Insights	📄 Logs
`Fast DDS Ubuntu CI`	`ubuntu-ci / fastdds_build (RelWithDebInfo)`	Base branch is broken, but the job passed. Looks like this might be a real fix 💪		`0`	View	View

cferreiragonz

LGTM with green CI

cferreiragonz · 2026-01-21T08:39:52Z

@Mergifyio backport 3.4.x 3.3.x 3.2.x 2.14.x

mergify · 2026-01-21T08:39:56Z

backport 3.4.x 3.3.x 3.2.x 2.14.x

✅ Backports have been created

Details

#6266 [24101] Fix build in GCC 15 (backport #6263) has been created for branch 3.4.x
#6267 [24101] Fix build in GCC 15 (backport #6263) has been created for branch 3.3.x
#6268 [24101] Fix build in GCC 15 (backport #6263) has been created for branch 3.2.x
#6269 [24101] Fix build in GCC 15 (backport #6263) has been created for branch 2.14.x but encountered conflicts

Cherry-pick of 8b28dab has failed:

On branch mergify/bp/2.14.x/pr-6263
Your branch is up to date with 'origin/2.14.x'.

You are currently cherry-picking commit 8b28dabf3.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   include/fastdds/rtps/security/common/SharedSecretHandle.h
	modified:   src/cpp/rtps/persistence/sqlite3.c

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   test/dds/communication/dyn_network/Dockerfile

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

* Include cstdint needed in g++ 15.2.0 Signed-off-by: Raül <raulojeda@eprosima.com> * Add Security and Statistics features in the alternative build workflow Signed-off-by: Raül <raulojeda@eprosima.com> * Suprpess false positive warning in GCC 15 at sqlite3.c Signed-off-by: Raül <raulojeda@eprosima.com> * Add missing cmake-args and includes in alphabetical order Signed-off-by: Raül <raulojeda@eprosima.com> --------- Signed-off-by: Raül <raulojeda@eprosima.com> (cherry picked from commit 8b28dab)

* Include cstdint needed in g++ 15.2.0 Signed-off-by: Raül <raulojeda@eprosima.com> * Add Security and Statistics features in the alternative build workflow Signed-off-by: Raül <raulojeda@eprosima.com> * Suprpess false positive warning in GCC 15 at sqlite3.c Signed-off-by: Raül <raulojeda@eprosima.com> * Add missing cmake-args and includes in alphabetical order Signed-off-by: Raül <raulojeda@eprosima.com> --------- Signed-off-by: Raül <raulojeda@eprosima.com> (cherry picked from commit 8b28dab) # Conflicts: # test/dds/communication/dyn_network/Dockerfile

* Fix build in GCC 15 (#6263) * Include cstdint needed in g++ 15.2.0 Signed-off-by: Raül <raulojeda@eprosima.com> * Add Security and Statistics features in the alternative build workflow Signed-off-by: Raül <raulojeda@eprosima.com> * Suprpess false positive warning in GCC 15 at sqlite3.c Signed-off-by: Raül <raulojeda@eprosima.com> * Add missing cmake-args and includes in alphabetical order Signed-off-by: Raül <raulojeda@eprosima.com> --------- Signed-off-by: Raül <raulojeda@eprosima.com> (cherry picked from commit 8b28dab) # Conflicts: # test/dds/communication/dyn_network/Dockerfile * Fix conflict Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> --------- Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> Co-authored-by: Raül Ojeda Gandia <raulojeda@eprosima.com> Co-authored-by: Emilio Cuesta <emiliocuesta@eprosima.com>

* Include cstdint needed in g++ 15.2.0 * Add Security and Statistics features in the alternative build workflow * Suprpess false positive warning in GCC 15 at sqlite3.c * Add missing cmake-args and includes in alphabetical order --------- (cherry picked from commit 8b28dab) Signed-off-by: Raül <raulojeda@eprosima.com> Co-authored-by: Raül Ojeda Gandia <raulojeda@eprosima.com>

* Include cstdint needed in g++ 15.2.0 Signed-off-by: Raül <raulojeda@eprosima.com> * Add Security and Statistics features in the alternative build workflow Signed-off-by: Raül <raulojeda@eprosima.com> * Suprpess false positive warning in GCC 15 at sqlite3.c Signed-off-by: Raül <raulojeda@eprosima.com> * Add missing cmake-args and includes in alphabetical order Signed-off-by: Raül <raulojeda@eprosima.com> --------- Signed-off-by: Raül <raulojeda@eprosima.com> (cherry picked from commit 8b28dab)

* Include cstdint needed in g++ 15.2.0 * Add Security and Statistics features in the alternative build workflow * Suprpess false positive warning in GCC 15 at sqlite3.c * Add missing cmake-args and includes in alphabetical order --------- (cherry picked from commit 8b28dab) Signed-off-by: Raül <raulojeda@eprosima.com> Co-authored-by: Raül Ojeda Gandia <raulojeda@eprosima.com>

Include cstdint needed in g++ 15.2.0

623e5cf

Signed-off-by: Raül <raulojeda@eprosima.com>

raulojeda22 added this to the v3.5.0 milestone Jan 20, 2026

cferreiragonz requested changes Jan 20, 2026

View reviewed changes

Add Security and Statistics features in the alternative build workflow

f191a1e

Signed-off-by: Raül <raulojeda@eprosima.com>

raulojeda22 requested a review from cferreiragonz January 20, 2026 10:44

github-actions bot added the ci-pending PR which CI is running label Jan 20, 2026

Suprpess false positive warning in GCC 15 at sqlite3.c

e6bd82a

Signed-off-by: Raül <raulojeda@eprosima.com>

raulojeda22 changed the title ~~[24101] Include cstdint needed in GCC 15~~ [24101] Fix build in GCC 15 Jan 20, 2026

cferreiragonz requested changes Jan 20, 2026

View reviewed changes

.github/workflows/docker/ubuntu/alternative_builds/fastdds_gcc_latest.Dockerfile Outdated Show resolved Hide resolved

src/cpp/rtps/security/common/SharedSecretHandle.h Show resolved Hide resolved

Add missing cmake-args and includes in alphabetical order

37e96d5

Signed-off-by: Raül <raulojeda@eprosima.com>

raulojeda22 requested a review from cferreiragonz January 20, 2026 13:08

cferreiragonz approved these changes Jan 21, 2026

View reviewed changes

cferreiragonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jan 21, 2026

juanlofer-eprosima merged commit 8b28dab into master Jan 21, 2026
42 of 46 checks passed

juanlofer-eprosima deleted the bugfix/cstdint-security branch January 21, 2026 08:38

mergify bot mentioned this pull request Jan 21, 2026

[24101] Fix build in GCC 15 (backport #6263) #6266

Merged

10 tasks

mergify bot mentioned this pull request Jan 21, 2026

[24101] Fix build in GCC 15 (backport #6263) #6267

Merged

10 tasks

mergify bot mentioned this pull request Jan 21, 2026

[24101] Fix build in GCC 15 (backport #6263) #6268

Merged

10 tasks

mergify bot mentioned this pull request Jan 21, 2026

[24101] Fix build in GCC 15 (backport #6263) #6269

Merged

10 tasks

MiguelCompany mentioned this pull request Feb 3, 2026

Add missing include for cstdint in SharedSecretHandle.cpp #6293

Open

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[24101] Fix build in GCC 15#6263

[24101] Fix build in GCC 15#6263
juanlofer-eprosima merged 4 commits intomasterfrom
bugfix/cstdint-security

raulojeda22 commented Jan 20, 2026 •

edited by cferreiragonz

Loading

Uh oh!

cferreiragonz left a comment

Uh oh!

Uh oh!

Uh oh!

mergify bot commented Jan 20, 2026 •

edited

Loading

Uh oh!

cferreiragonz left a comment

Uh oh!

Uh oh!

cferreiragonz commented Jan 21, 2026

Uh oh!

mergify bot commented Jan 21, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

raulojeda22 commented Jan 20, 2026 • edited by cferreiragonz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

cferreiragonz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mergify bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 CI Insights

❌ Job Failures

✅ Passed Jobs With Interesting Signals

Uh oh!

cferreiragonz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cferreiragonz commented Jan 21, 2026

Uh oh!

mergify bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

raulojeda22 commented Jan 20, 2026 •

edited by cferreiragonz

Loading

mergify bot commented Jan 20, 2026 •

edited

Loading

mergify bot commented Jan 21, 2026 •

edited

Loading