Skip to content

[24101] Fix build in GCC 15 (backport #6263)#6268

Merged
MiguelCompany merged 1 commit into3.2.xfrom
mergify/bp/3.2.x/pr-6263
Feb 6, 2026
Merged

[24101] Fix build in GCC 15 (backport #6263)#6268
MiguelCompany merged 1 commit into3.2.xfrom
mergify/bp/3.2.x/pr-6263

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Jan 21, 2026

Description

Fix compilation with GCC 15 by adding missing #include <cstdint> to SharedSecretHandle.h.
GCC 15 is stricter about implicit includes, and uint8_t requires an explicit #include <cstdint>. Without this include, compilation fails with errors like:

error: 'uint8_t' was not declared in this scope

Additionally, GCC 15 shows a false positive warning in sqlite3.c:

warning: ‘strlen’ reading 1 or more bytes from a region of size 0 [-Wstringop-overread]
35253 |   return 0x3fffffff & (int)strlen(z);

Which is fixed in this PR by changing the if statement to a ternary operator.

@Mergifyio backport 3.4.x 3.3.x 3.2.x 2.14.x

Fixes #6254

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A Any new/modified methods have been properly documented using Doxygen.

  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #6263 done by [Mergify](https://mergify.com).

@mergify mergify bot mentioned this pull request Jan 21, 2026
10 tasks
@cferreiragonz cferreiragonz added this to the v3.2.4 milestone Jan 21, 2026
@MiguelCompany
Copy link
Copy Markdown
Member

@Mergifyio rebase

* Include cstdint needed in g++ 15.2.0

Signed-off-by: Raül <raulojeda@eprosima.com>

* Add Security and Statistics features in the alternative build workflow

Signed-off-by: Raül <raulojeda@eprosima.com>

* Suprpess false positive warning in GCC 15 at sqlite3.c

Signed-off-by: Raül <raulojeda@eprosima.com>

* Add missing cmake-args and includes in alphabetical order

Signed-off-by: Raül <raulojeda@eprosima.com>

---------

Signed-off-by: Raül <raulojeda@eprosima.com>
(cherry picked from commit 8b28dab)
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Feb 6, 2026

rebase

✅ Branch has been successfully rebased

@MiguelCompany MiguelCompany force-pushed the mergify/bp/3.2.x/pr-6263 branch from d9a8933 to 3772a35 Compare February 6, 2026 07:25
@MiguelCompany MiguelCompany self-requested a review February 6, 2026 07:26
@github-actions github-actions bot added the ci-pending PR which CI is running label Feb 6, 2026
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Feb 6, 2026

🧪 CI Insights

Here's what we observed from your CI run for 3772a35.

❌ Job Failures

Pipeline Job Health on 3.2.x Retries 🔍 CI Insights 📄 Logs
Fast DDS MacOS CI mac-ci / fastdds_test () Unknown 0 View View
Fast DDS Ubuntu CI ubuntu-ci / fastdds_discovery_server_test (RelWithDebInfo) Unknown 0 View View

@MiguelCompany MiguelCompany merged commit dd3e1d4 into 3.2.x Feb 6, 2026
26 of 28 checks passed
@MiguelCompany MiguelCompany deleted the mergify/bp/3.2.x/pr-6263 branch February 6, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants