Skip to content

[23782] Remote writers considered volatile by default#6085

Merged
MiguelCompany merged 3 commits intomasterfrom
bugfix/23778
Oct 9, 2025
Merged

[23782] Remote writers considered volatile by default#6085
MiguelCompany merged 3 commits intomasterfrom
bugfix/23778

Conversation

@MiguelCompany
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany commented Oct 8, 2025 •
edited by cferreiragonz
Loading

Description

@Mergifyio backport 3.3.x 3.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany
Refs #23778. Regression test.
411d1a8 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #23778. Fix issue.
6a084c1 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany added this to the v3.4.1 milestone Oct 8, 2025
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 8, 2025
@MiguelCompany
Refs #23778. Improved solution.
8b0bf00 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany requested review from cferreiragonz and removed request for cferreiragonz October 8, 2025 09:54
cferreiragonz
cferreiragonz approved these changes Oct 8, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cferreiragonz cferreiragonz changed the title [23782] Remote writers considered volitile by default [23782] Remote writers considered volatile by default Oct 8, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 8, 2025

🧪 CI Insights

Here's what we observed from your CI run for 8b0bf00.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
Fast DDS MacOS CI mac-ci / fastdds_test () Unknown 0 View View
Fast DDS Windows CI windows-ci / fastdds_test (RelWithDebInfo, examples), v142 Unknown 0 View View

@cferreiragonz cferreiragonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Oct 9, 2025
@MiguelCompany MiguelCompany merged commit 0e7204f into master Oct 9, 2025
26 of 28 checks passed
@MiguelCompany MiguelCompany deleted the bugfix/23778 branch October 9, 2025 05:47
@MiguelCompany
Copy link
Copy Markdown
Member Author

MiguelCompany commented Oct 9, 2025

@Mergifyio backport 3.3.x 3.2.x 2.14.x

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 9, 2025 •
edited
Loading

backport 3.3.x 3.2.x 2.14.x

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Oct 9, 2025
@MiguelCompany @mergify
Remote writers considered volatile by default (#6085)
a914d91 
* Refs #23778. Regression test.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23778. Fix issue.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23778. Improved solution.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 0e7204f)
mergify bot pushed a commit that referenced this pull request Oct 9, 2025
@MiguelCompany @mergify
Remote writers considered volatile by default (#6085)
472be4d 
* Refs #23778. Regression test.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23778. Fix issue.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23778. Improved solution.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 0e7204f)
mergify bot pushed a commit that referenced this pull request Oct 9, 2025
@MiguelCompany @mergify
Remote writers considered volatile by default (#6085)
25d3a2d 
* Refs #23778. Regression test.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23778. Fix issue.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23778. Improved solution.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 0e7204f)

# Conflicts:
#	src/cpp/rtps/builtin/data/WriterProxyData.cpp
#	test/unittest/rtps/builtin/BuiltinDataSerializationTests.cpp
This was referenced Oct 9, 2025
Merged
Merged
Merged
MiguelCompany added a commit that referenced this pull request Oct 9, 2025
@MiguelCompany
Remote writers considered volatile by default (#6085)
3b0fb14 
* Refs #23778. Regression test.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23778. Fix issue.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23778. Improved solution.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 0e7204f)
MiguelCompany added a commit that referenced this pull request Oct 9, 2025
@mergify @MiguelCompany
Remote writers considered volatile by default (#6085) (#6088)
a552a33 
* Remote writers considered volatile by default (#6085)

* Refs #23778. Regression test.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23778. Fix issue.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23778. Improved solution.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 0e7204f)

# Conflicts:
#	src/cpp/rtps/builtin/data/WriterProxyData.cpp
#	test/unittest/rtps/builtin/BuiltinDataSerializationTests.cpp

* Fix conflicts in WriterProxyData.cpp

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Fix conflicts in test

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany added a commit that referenced this pull request Oct 10, 2025
@mergify @MiguelCompany
Remote writers considered volatile by default (#6085) (#6087)
0f22af3 
* Refs #23778. Regression test.



* Refs #23778. Fix issue.



* Refs #23778. Improved solution.



---------


(cherry picked from commit 0e7204f)

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany added a commit that referenced this pull request Oct 10, 2025
@MiguelCompany
Remote writers considered volatile by default (#6085)
67539fa 
* Refs #23778. Regression test.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23778. Fix issue.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23778. Improved solution.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 0e7204f)
MiguelCompany added a commit that referenced this pull request Oct 10, 2025
@mergify @MiguelCompany
Remote writers considered volatile by default (#6085) (#6086)
d631657 
* Refs #23778. Regression test.



* Refs #23778. Fix issue.



* Refs #23778. Improved solution.



---------


(cherry picked from commit 0e7204f)

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cferreiragonz cferreiragonz cferreiragonz approved these changes

Assignees

No one assigned

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Milestone

v3.4.1 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

2 participants

@MiguelCompany @cferreiragonz