[21009] Do not require PYTHON_VERSION to be defined in .bat files (backport #4770)#4798
Merged
[21009] Do not require PYTHON_VERSION to be defined in .bat files (backport #4770)#4798
Conversation
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit 39e8957)
8 tasks
Contributor
|
@richiprosima please test this |
9 tasks
Contributor
|
Ci issues seem unrelated to the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@MiguelCompany identified an error introduced in #4759 as the
PYTHON_VERSIONdoes not necessarily need to be defined when executing thefastdds.batorros-discovery.batscripts.The change simply requires a specific version of Python only if
PYTHON_VERSIONis defined.Tested on Windows.
@Mergifyio backport 2.14.x 2.13.x
Cherry-pick on #4765 and #4766
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are ABI compatible.
Changes are API compatible.
N/A New feature has been added to the
versions.mdfile (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #4770 done by [Mergify](https://mergify.com).