Merged
Conversation
Member
|
Build status:
|
richiware
requested changes
Apr 9, 2019
Member
richiware
left a comment
There was a problem hiding this comment.
QoS should be configurable through XML:
EDP should check also this QoS when matching entities.
…classes to be able to get the resource event
…d so that the cache change can be removed from the subscriber if is received after it has expired
…roy() in TimedCallback destructor
…the history is not the one that started the timer. This can happen for instance if a change starts the timer but it is later removed from the history
… the C++ example and updating example documentation accordingly
…logic when ack timer expires has to be changed
17f4b3d to
a820cc2
Compare
Member
|
Build status:
|
Member
|
Build status:
|
added 3 commits
April 22, 2019 15:34
Contributor
Author
|
I believe I have addressed all the review changes, including EDP matching and XML configuration |
Member
|
Build status:
|
richiware
approved these changes
Apr 23, 2019
Member
|
Build status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new QoS to disable positive ACKs. Adds a C++ example and blackbox tests.