Skip to content

[21153, 21154] Address XMLDynamicParser Fuzzer regressions #4939

Merged
EduPonz merged 3 commits intomasterfrom
bugfix/21153
Jun 12, 2024
Merged

[21153, 21154] Address XMLDynamicParser Fuzzer regressions #4939
EduPonz merged 3 commits intomasterfrom
bugfix/21153

Conversation

@Mario-DL
Copy link
Copy Markdown
Contributor

@Mario-DL Mario-DL commented Jun 12, 2024

Description

This PR addresses some XML fuzzer regressions that affects DynamicTypes Parsing. It is for that reason that there are no backports. In summary, it was a non-captured std::out_of_range exception and a nullptr check missing. I tried also protecting analogous code snippets within the file.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • NO New feature has been added to the versions.md file (if applicable).
  • NO New feature has been documented/Current behavior is correctly described in the documentation.
  • ❌ Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Mario-DL added 2 commits June 12, 2024 09:51
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL added this to the v3.0.0 milestone Jun 12, 2024
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL requested a review from JesusPoderoso June 12, 2024 08:02
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 12, 2024
Copy link
Copy Markdown
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@EduPonz EduPonz merged commit 1f6a231 into master Jun 12, 2024
@EduPonz EduPonz deleted the bugfix/21153 branch June 12, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants