[20629] GUIDLess Discovery Server#4716
Merged
MiguelCompany merged 51 commits intomasterfrom Jul 3, 2024
Merged
Conversation
dcea616 to
5209472
Compare
7 tasks
f90602a to
a12d3ef
Compare
dcc705f to
6380fb3
Compare
6380fb3 to
77acce1
Compare
77acce1 to
4d2244d
Compare
2f68ecc to
105294a
Compare
11 tasks
a2ab9b9 to
1a59486
Compare
105294a to
a9dfd62
Compare
1a59486 to
2481446
Compare
a9dfd62 to
904b75b
Compare
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
…scovery of TST Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
09e9f9a to
688cd0f
Compare
MiguelCompany
requested changes
Jul 1, 2024
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
MiguelCompany
previously approved these changes
Jul 2, 2024
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Contributor
Author
|
Green CI. Updating |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR drastically changes Discovery Server behavior to be able to work without a fixed GUID.
Servers and Clients now connect between each other by exclusively specifying a locator, the GUID is not needed anymore. The remote server list has been replaced with LocatorList.
Hence, the server_id parameter used in the CLI and the positional arguments in the environment variable are deprecated. The -i parameter in the CLI has been kept in order to guarantee backward compatibility, but it is not mandatory any longer.
Servers now use a mesh topology, meaning that every server will directly connect with all of the available servers.
In order to accomplish last point, Servers now send the Data(p) of connected servers to new servers connections and send the Data(p) of the new server to all connected servers. To connect a new server to the mesh, it is only needed to specify the locator of an already connected server.
Servers only redirect discovery information of their direct clients, and will stop redirecting discovery information of the clients of other servers.
Remote Discovery servers connection list can now be updated at runtime without any restrictions. The previous list does not need to be a subset of the new one.
Servers now use the lease announcements routine to make connections with the remote servers specified in the remote Discovery servers list. Initial announcements will be called again every time a known server is dropped or the remote server list is updated.
Clients now accept connections of any server, not only the ones specified in their remote Discovery servers list. Although in normal behavior a client will only receive discovery information of the servers pinged by itself, if it receives a Data(p) of an other server (sending it manually) it will try to make a connection.
ServerAttributes is now private, as it is no longer needed to configure Clients or Servers
This PR is on top of [20936] Change backup restore order #4740 and must be merged after it
It also affects the python API: [20629] GUIDLess Discovery Server - Make ServerAttributes private Fast-DDS-python#147
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist