Skip to content

[20936] Change backup restore order#4740

Merged
MiguelCompany merged 2 commits intomasterfrom
bugfix/backup_restore
Jun 13, 2024
Merged

[20936] Change backup restore order#4740
MiguelCompany merged 2 commits intomasterfrom
bugfix/backup_restore

Conversation

@cferreiragonz
Copy link
Copy Markdown
Contributor

@cferreiragonz cferreiragonz commented Apr 29, 2024

Description

This PR postpones the execution of the process_backup_discovery_database_restore method until after the initialization of builtinProtocols and the TypeLookUpManager.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally: [20936] Change backup restore order Discovery-Server#77
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@cferreiragonz cferreiragonz added this to the v3.0.0 milestone Apr 29, 2024
@cferreiragonz cferreiragonz added the needs-review PR that is ready to be reviewed label May 6, 2024
@cferreiragonz cferreiragonz force-pushed the bugfix/backup_restore branch from fc418d3 to a2ab9b9 Compare May 10, 2024 11:03
@cferreiragonz cferreiragonz force-pushed the bugfix/backup_restore branch from a2ab9b9 to 1a59486 Compare May 13, 2024 08:16
@EduPonz EduPonz deleted the branch master May 14, 2024 07:22
@EduPonz EduPonz closed this May 14, 2024
@EduPonz EduPonz reopened this May 14, 2024
@EduPonz EduPonz changed the base branch from 3.0.x-devel to master May 14, 2024 07:27
@cferreiragonz cferreiragonz force-pushed the bugfix/backup_restore branch from 1a59486 to 2481446 Compare May 14, 2024 08:20
@cferreiragonz cferreiragonz force-pushed the bugfix/backup_restore branch from 2481446 to 8011f40 Compare May 28, 2024 14:40
@cferreiragonz cferreiragonz force-pushed the bugfix/backup_restore branch from 8011f40 to 233434f Compare June 10, 2024 13:24
Comment thread src/cpp/rtps/builtin/discovery/participant/PDP.h Outdated
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz cferreiragonz force-pushed the bugfix/backup_restore branch from 233434f to d490fad Compare June 12, 2024 11:03
@MiguelCompany
Copy link
Copy Markdown
Member

@richiprosima Please test_3 discovery-server

@MiguelCompany MiguelCompany self-requested a review June 12, 2024 12:44
@github-actions github-actions Bot added the ci-pending PR which CI is running label Jun 12, 2024
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany removed the needs-review PR that is ready to be reviewed label Jun 12, 2024
@MiguelCompany MiguelCompany merged commit 5273c6e into master Jun 13, 2024
@MiguelCompany MiguelCompany deleted the bugfix/backup_restore branch June 13, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants