[20592][20679] Fix hidden overloaded virtual methods#4624
Merged
MiguelCompany merged 5 commits into2.10.xfrom Apr 4, 2024
Merged
[20592][20679] Fix hidden overloaded virtual methods#4624MiguelCompany merged 5 commits into2.10.xfrom
MiguelCompany merged 5 commits into2.10.xfrom
Conversation
This was referenced Mar 26, 2024
Member
|
@Mergifyio rebase |
Contributor
✅ Branch has been successfully rebased |
44c0cff to
e209710
Compare
MiguelCompany
previously approved these changes
Apr 1, 2024
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
e209710 to
1c00b30
Compare
MiguelCompany
requested changes
Apr 2, 2024
f78a5ed to
670c7c7
Compare
MiguelCompany
requested changes
Apr 2, 2024
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
670c7c7 to
e1576a3
Compare
Member
|
@richiprosima Please test this |
Member
|
@richiprosima please test mac |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a backport combining:
Before this PR, compiling with GCC option
-Woverloaded-virtualresulted in compilation warnings due to overloaded virtual methods being hidden in derived classes that do not override all the parent's overloads. This PR:pull_requesteventsIt substitutes:
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist