Skip to content

[20592][20679] Fix hidden overloaded virtual methods#4624

Merged
MiguelCompany merged 5 commits into2.10.xfrom
hotfix/hidden_overloads/2.10.x
Apr 4, 2024
Merged

[20592][20679] Fix hidden overloaded virtual methods#4624
MiguelCompany merged 5 commits into2.10.xfrom
hotfix/hidden_overloads/2.10.x

Conversation

@EduPonz
Copy link
Copy Markdown

@EduPonz EduPonz commented Mar 26, 2024

Description

This PR is a backport combining:

Before this PR, compiling with GCC option -Woverloaded-virtual resulted in compilation warnings due to overloaded virtual methods being hidden in derived classes that do not override all the parent's overloads. This PR:

  1. Fixes all those warnings
  2. Adds more warning reporting options GCC in Ubuntu CI on Github
  3. Enables running Github Ubuntu CI on pull_request events
  4. Enables running Github CI on PRs targeting intermediate branches

It substitutes:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany
Copy link
Copy Markdown
Member

@Mergifyio rebase

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 1, 2024

rebase

✅ Branch has been successfully rebased

@MiguelCompany MiguelCompany force-pushed the hotfix/hidden_overloads/2.10.x branch from 44c0cff to e209710 Compare April 1, 2024 12:45
MiguelCompany
MiguelCompany previously approved these changes Apr 1, 2024
@MiguelCompany MiguelCompany added the ci-pending PR which CI is running label Apr 1, 2024
EduPonz added 4 commits April 2, 2024 11:38
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Comment thread test/performance/latency/LatencyTestTypes.hpp Outdated
Comment thread test/unittest/dds/subscriber/DataReaderHistoryTests.cpp Outdated
Comment thread test/unittest/dds/topic/TopicTests.cpp Outdated
@EduPonz EduPonz force-pushed the hotfix/hidden_overloads/2.10.x branch from f78a5ed to 670c7c7 Compare April 2, 2024 10:57
Comment thread test/unittest/dds/publisher/DataWriterTests.cpp Outdated
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz force-pushed the hotfix/hidden_overloads/2.10.x branch from 670c7c7 to e1576a3 Compare April 2, 2024 12:11
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany
Copy link
Copy Markdown
Member

@richiprosima Please test this

@MiguelCompany
Copy link
Copy Markdown
Member

@richiprosima please test mac

@MiguelCompany MiguelCompany merged commit d14933d into 2.10.x Apr 4, 2024
@MiguelCompany MiguelCompany deleted the hotfix/hidden_overloads/2.10.x branch April 4, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants