[20592] Fix hidden overloaded virtual methods by EduPonz · Pull Request #4516 · eProsima/Fast-DDS

EduPonz · 2024-03-06T09:29:11Z

Description

Before this PR, compiling with GCC option -Woverloaded-virtual resulted in compilation warnings due to overloaded virtual methods being hidden in derived classes that do not override all the parent's overloads. This PR:

Fixes all those warnings
Adds more warning reporting options GCC in Ubuntu CI on Github

@Mergifyio backport 2.13.x 2.12.x 2.10.x 2.6.x

Contributor Checklist

Commit messages follow the project guidelines.
N/A: The code follows the style guidelines of this project.
N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A: Any new/modified methods have been properly documented using Doxygen.
Changes are ABI compatible.
Changes are API compatible.
N/A: New feature has been added to the versions.md file (if applicable).
N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

EduPonz · 2024-03-07T09:10:27Z

@richiprosima please test this

MiguelCompany

Windows related warning: 'eprosima::fastrtps::rtps::PDP::announceParticipantState': ambiguous call to overloaded function

See related suggestion below

src/cpp/rtps/builtin/discovery/participant/PDPClient.h

EduPonz · 2024-03-12T10:40:01Z

@richiprosima please test this

MiguelCompany

LGTM with green CI

The merge-base changed after approval.

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

…articipantState Signed-off-by: EduPonz <eduardoponz@eprosima.com>

EduPonz · 2024-03-20T06:19:35Z

@richiprosima please test this

EduPonz · 2024-03-20T11:32:29Z

@richiprosima please test windows test mac

EduPonz · 2024-03-20T18:48:35Z

@Mergifyio backport 2.13.x 2.10.x 2.6.x

mergify · 2024-03-20T18:48:42Z

backport 2.13.x 2.10.x 2.6.x

✅ Backports have been created

Details

#4591 [20592] Fix hidden overloaded virtual methods (backport #4516) has been created for branch 2.13.x but encountered conflicts
#4592 [20592] Fix hidden overloaded virtual methods (backport #4516) has been created for branch 2.10.x but encountered conflicts
#4593 [20592] Fix hidden overloaded virtual methods (backport #4516) has been created for branch 2.6.x but encountered conflicts

* Refs #20592: Fix for test Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20592: Fix for examples Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20592: Add more warning flags to Ubuntu CI Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20592: Remove default values on overloaded PDPClient::announceParticipantState Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit 63cc242) # Conflicts: # .github/workflows/reusable-ubuntu-ci.yml # test/dds/communication/security/PublisherModule.hpp # test/dds/communication/security/SubscriberModule.hpp

* Refs #20592: Fix for test Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20592: Fix for examples Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20592: Add more warning flags to Ubuntu CI Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20592: Remove default values on overloaded PDPClient::announceParticipantState Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit 63cc242) # Conflicts: # .github/workflows/reusable-ubuntu-ci.yml # examples/cpp/dds/DiscoveryServerExample/DiscoveryServerPublisher.h # examples/cpp/dds/DiscoveryServerExample/DiscoveryServerServer.h # examples/cpp/dds/DiscoveryServerExample/DiscoveryServerSubscriber.h # test/blackbox/common/DDSBlackboxTestsDataRepresentationQos.cpp # test/blackbox/common/DDSBlackboxTestsDiscovery.cpp # test/dds/communication/security/PublisherModule.hpp # test/dds/communication/security/SubscriberModule.hpp # test/unittest/statistics/dds/StatisticsDomainParticipantStatusQueryableTests.cpp

* Refs #20592: Fix for test Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20592: Fix for examples Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20592: Add more warning flags to Ubuntu CI Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20592: Remove default values on overloaded PDPClient::announceParticipantState Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit 63cc242) # Conflicts: # .github/workflows/reusable-ubuntu-ci.yml # examples/C++/RTPSTest_persistent/TestReaderPersistent.h # examples/C++/RTPSTest_persistent/TestWriterPersistent.h # examples/C++/RTPSTest_registered/TestReaderRegistered.h # examples/C++/RTPSTest_registered/TestWriterRegistered.h # examples/cpp/dds/DiscoveryServerExample/DiscoveryServerServer.h # src/cpp/rtps/builtin/discovery/participant/timedevent/DSClientEvent.cpp # test/blackbox/common/DDSBlackboxTestsBasic.cpp # test/blackbox/common/DDSBlackboxTestsDataRepresentationQos.cpp # test/blackbox/common/DDSBlackboxTestsDiscovery.cpp # test/blackbox/common/DDSBlackboxTestsFindTopic.cpp # test/dds/communication/SubscriberDynamic.cpp # test/dds/communication/security/PublisherModule.hpp # test/dds/communication/security/SubscriberModule.hpp # test/unittest/dds/participant/ParticipantTests.cpp # test/unittest/dds/subscriber/DataReaderHistoryTests.cpp # test/unittest/statistics/dds/StatisticsDomainParticipantStatusQueryableTests.cpp

EduPonz added this to the v2.14.1 milestone Mar 6, 2024

MiguelCompany self-requested a review March 11, 2024 13:25

MiguelCompany approved these changes Mar 11, 2024

View reviewed changes

MiguelCompany requested changes Mar 11, 2024

View reviewed changes

src/cpp/rtps/builtin/discovery/participant/PDPClient.h Outdated Show resolved Hide resolved

EduPonz force-pushed the hotfix/hidden_overloaded_virtuals branch from 5c978d0 to 431a3fc Compare March 12, 2024 10:39

MiguelCompany previously approved these changes Mar 12, 2024

View reviewed changes

MiguelCompany added the ci-pending PR which CI is running label Mar 12, 2024

MiguelCompany force-pushed the master branch from 74b2a74 to 3557063 Compare March 13, 2024 07:11

EduPonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Mar 13, 2024

MiguelCompany added the temporarily-blocked PR must be merged after another one label Mar 13, 2024

EduPonz added 4 commits March 20, 2024 07:17

Refs #20592: Fix for test

f5e7f3d

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

Refs #20592: Fix for examples

ef41578

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

Refs #20592: Add more warning flags to Ubuntu CI

db4d6ee

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

Refs #20592: Remove default values on overloaded PDPClient::announceP…

6a15ead

…articipantState Signed-off-by: EduPonz <eduardoponz@eprosima.com>

EduPonz force-pushed the hotfix/hidden_overloaded_virtuals branch from 431a3fc to 6a15ead Compare March 20, 2024 06:18

EduPonz added ci-pending PR which CI is running and removed ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. temporarily-blocked PR must be merged after another one labels Mar 20, 2024

EduPonz removed the ci-pending PR which CI is running label Mar 20, 2024

EduPonz merged commit 63cc242 into master Mar 20, 2024

EduPonz deleted the hotfix/hidden_overloaded_virtuals branch March 20, 2024 18:48

This was referenced Mar 20, 2024

[20592] Fix hidden overloaded virtual methods (backport #4516) #4591

Closed

[20592] Fix hidden overloaded virtual methods (backport #4516) #4592

Closed

mergify bot mentioned this pull request Mar 20, 2024

[20592] Fix hidden overloaded virtual methods (backport #4516) #4593

Closed

9 tasks

EduPonz mentioned this pull request Mar 21, 2024

[20679] Run Github Ubuntu CI on PRs #4598

Merged

10 tasks

This was referenced Mar 22, 2024

[20679] Run Github Ubuntu CI on PRs (backport #4598) #4600

Closed

[20679] Run Github Ubuntu CI on PRs (backport #4598) #4601

Closed

[20679] Run Github Ubuntu CI on PRs (backport #4598) #4602

Closed

This was referenced Mar 26, 2024

[20592][20679] Fix hidden overloaded virtual methods #4622

Merged

[20592][20679] Fix hidden overloaded virtual methods #4624

Merged

[20592][20679] Fix hidden overloaded virtual methods #4625

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[20592] Fix hidden overloaded virtual methods#4516

[20592] Fix hidden overloaded virtual methods#4516
EduPonz merged 4 commits intomasterfrom
hotfix/hidden_overloaded_virtuals

EduPonz commented Mar 6, 2024 •

edited

Loading

Uh oh!

EduPonz commented Mar 7, 2024

Uh oh!

MiguelCompany left a comment

Uh oh!

Uh oh!

EduPonz commented Mar 12, 2024

Uh oh!

MiguelCompany left a comment

Uh oh!

EduPonz commented Mar 20, 2024

Uh oh!

EduPonz commented Mar 20, 2024

Uh oh!

EduPonz commented Mar 20, 2024

Uh oh!

mergify bot commented Mar 20, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

EduPonz commented Mar 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

EduPonz commented Mar 7, 2024

Uh oh!

MiguelCompany left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

EduPonz commented Mar 12, 2024

Uh oh!

MiguelCompany left a comment

Choose a reason for hiding this comment

Uh oh!

EduPonz commented Mar 20, 2024

Uh oh!

EduPonz commented Mar 20, 2024

Uh oh!

EduPonz commented Mar 20, 2024

Uh oh!

mergify bot commented Mar 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

EduPonz commented Mar 6, 2024 •

edited

Loading

mergify bot commented Mar 20, 2024 •

edited

Loading