Skip to content

[20592] Fix hidden overloaded virtual methods (backport #4516)#4591

Closed
mergify[bot] wants to merge 2 commits into2.13.xfrom
mergify/bp/2.13.x/pr-4516
Closed

[20592] Fix hidden overloaded virtual methods (backport #4516)#4591
mergify[bot] wants to merge 2 commits into2.13.xfrom
mergify/bp/2.13.x/pr-4516

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Mar 20, 2024

Description

Before this PR, compiling with GCC option -Woverloaded-virtual resulted in compilation warnings due to overloaded virtual methods being hidden in derived classes that do not override all the parent's overloads. This PR:

  1. Fixes all those warnings
  2. Adds more warning reporting options GCC in Ubuntu CI on Github

@Mergifyio backport 2.13.x 2.12.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • N/A: The code follows the style guidelines of this project.

  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A: Any new/modified methods have been properly documented using Doxygen.

  • Changes are ABI compatible.

  • Changes are API compatible.

  • N/A: New feature has been added to the versions.md file (if applicable).

  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.
This is an automatic backport of pull request #4516 done by [Mergify](https://mergify.com).

@EduPonz @mergify
Fix hidden overloaded virtual methods (#4516)
1dbe74d 
* Refs #20592: Fix for test

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20592: Fix for examples

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20592: Add more warning flags to Ubuntu CI

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20592: Remove default values on overloaded PDPClient::announceParticipantState

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
(cherry picked from commit 63cc242)

# Conflicts:
#	.github/workflows/reusable-ubuntu-ci.yml
#	test/dds/communication/security/PublisherModule.hpp
#	test/dds/communication/security/SubscriberModule.hpp
@mergify mergify bot added the conflicts Backport PR wich git cherry pick failed label Mar 20, 2024
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Mar 20, 2024

Cherry-pick of 63cc242 has failed:

On branch mergify/bp/2.13.x/pr-4516
Your branch is up to date with 'origin/2.13.x'.

You are currently cherry-picking commit 63cc242b2.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   examples/cpp/dds/DiscoveryServerExample/DiscoveryServerPublisher.h
	modified:   examples/cpp/dds/DiscoveryServerExample/DiscoveryServerServer.h
	modified:   examples/cpp/dds/DiscoveryServerExample/DiscoveryServerSubscriber.h
	modified:   examples/cpp/dds/LivelinessQoS/LivelinessSubscriber.h
	modified:   examples/cpp/rtps/Persistent/TestReaderPersistent.h
	modified:   examples/cpp/rtps/Persistent/TestWriterPersistent.h
	modified:   examples/cpp/rtps/Registered/TestReaderRegistered.h
	modified:   examples/cpp/rtps/Registered/TestWriterRegistered.h
	modified:   src/cpp/rtps/builtin/discovery/participant/PDPClient.h
	modified:   src/cpp/rtps/builtin/discovery/participant/timedevent/DSClientEvent.cpp
	modified:   test/blackbox/api/dds-pim/PubSubParticipant.hpp
	modified:   test/blackbox/api/dds-pim/PubSubReader.hpp
	modified:   test/blackbox/api/dds-pim/PubSubWriter.hpp
	modified:   test/blackbox/api/dds-pim/PubSubWriterReader.hpp
	modified:   test/blackbox/common/DDSBlackboxTestsBasic.cpp
	modified:   test/blackbox/common/DDSBlackboxTestsDataRepresentationQos.cpp
	modified:   test/blackbox/common/DDSBlackboxTestsDiscovery.cpp
	modified:   test/blackbox/common/DDSBlackboxTestsFindTopic.cpp
	modified:   test/blackbox/common/RTPSWithRegistrationReader.hpp
	modified:   test/blackbox/common/RTPSWithRegistrationWriter.hpp
	modified:   test/dds/communication/PublisherDynamic.cpp
	modified:   test/dds/communication/PublisherModule.hpp
	modified:   test/dds/communication/SubscriberDynamic.cpp
	modified:   test/dds/communication/SubscriberModule.hpp
	modified:   test/dds/discovery/ParticipantModule.hpp
	modified:   test/performance/latency/LatencyTestTypes.hpp
	modified:   test/performance/throughput/ThroughputTypes.hpp
	modified:   test/unittest/dds/participant/ParticipantTests.cpp
	modified:   test/unittest/dds/publisher/DataWriterTests.cpp
	modified:   test/unittest/dds/publisher/PublisherTests.cpp
	modified:   test/unittest/dds/status/ListenerTests.cpp
	modified:   test/unittest/dds/subscriber/DataReaderHistoryTests.cpp
	modified:   test/unittest/dds/subscriber/DataReaderTests.cpp
	modified:   test/unittest/dds/subscriber/FooBoundedTypeSupport.hpp
	modified:   test/unittest/dds/subscriber/FooTypeSupport.hpp
	modified:   test/unittest/dds/topic/TopicTests.cpp
	modified:   test/unittest/statistics/dds/StatisticsDomainParticipantStatusQueryableTests.cpp
	modified:   test/unittest/statistics/dds/StatisticsDomainParticipantTests.cpp

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   .github/workflows/reusable-ubuntu-ci.yml
	deleted by us:   test/dds/communication/security/PublisherModule.hpp
	deleted by us:   test/dds/communication/security/SubscriberModule.hpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Mar 20, 2024
Merged
9 tasks
@EduPonz EduPonz added this to the v2.13.4 milestone Mar 20, 2024
@JesusPoderoso JesusPoderoso added ci-pending PR which CI is running and removed conflicts Backport PR wich git cherry pick failed labels Mar 25, 2024
@JesusPoderoso
Fix conflicts
8471393 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso mentioned this pull request Mar 25, 2024
Closed
10 tasks
@JesusPoderoso
Copy link
Copy Markdown
Contributor

JesusPoderoso commented Mar 25, 2024

@richiprosima please test this

@EduPonz EduPonz mentioned this pull request Mar 26, 2024
Merged
9 tasks
@EduPonz
Copy link
Copy Markdown

EduPonz commented Mar 26, 2024

Closed in favor of:

@EduPonz EduPonz closed this Mar 26, 2024
@mergify mergify bot deleted the mergify/bp/2.13.x/pr-4516 branch March 26, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ci-pending PR which CI is running first-to-merge

Projects

None yet

Milestone

v2.13.4

Development

Successfully merging this pull request may close these issues.

2 participants

@JesusPoderoso @EduPonz