Skip to content

[20679] Run Github Ubuntu CI on PRs#4598

Merged
EduPonz merged 3 commits intomasterfrom
ci/github_ubuntu_ci_prs
Mar 22, 2024
Merged

[20679] Run Github Ubuntu CI on PRs#4598
EduPonz merged 3 commits intomasterfrom
ci/github_ubuntu_ci_prs

Conversation

@EduPonz
Copy link
Copy Markdown

@EduPonz EduPonz commented Mar 21, 2024 •
edited
Loading

Description

This PR:

  1. Enables running Github Ubuntu CI on pull_request events.
  2. Fixes hidden overloads erroneously left out by [20592] Fix hidden overloaded virtual methods #4516
  3. Enables running Github CI on PRs targeting intermediate branches (not master).

@Mergifyio backport 2.13.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

EduPonz added 3 commits March 21, 2024 21:05
@EduPonz
Refs #20679: Run Github Ubuntu CI on PRs
71e796a 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Refs #20679: Fix remaining hidden overloads
80e0626 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Refs #20679: Run CI on PRs to intermediate branches
5b29744 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz added this to the v2.14.1 milestone Mar 21, 2024
@EduPonz
Copy link
Copy Markdown
Author

EduPonz commented Mar 21, 2024

@richiprosima please test this

@EduPonz
Copy link
Copy Markdown
Author

EduPonz commented Mar 21, 2024

@richiprosima please test mac

@JesusPoderoso JesusPoderoso mentioned this pull request Mar 21, 2024
Closed
7 tasks
@JesusPoderoso
Copy link
Copy Markdown
Contributor

JesusPoderoso commented Mar 22, 2024

@richiprosima please test this

JesusPoderoso

This comment was marked as outdated.

Sign in to view

@JesusPoderoso JesusPoderoso added the ci-pending PR which CI is running label Mar 22, 2024
@elianalf elianalf force-pushed the ci/github_ubuntu_ci_prs branch from db0d49f to 5b29744 Compare March 22, 2024 08:58
JesusPoderoso
JesusPoderoso approved these changes Mar 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@EduPonz
Copy link
Copy Markdown
Author

EduPonz commented Mar 22, 2024

CI passed on 5b29744

@EduPonz EduPonz merged commit 7154a57 into master Mar 22, 2024
@EduPonz EduPonz deleted the ci/github_ubuntu_ci_prs branch March 22, 2024 10:20
@EduPonz
Copy link
Copy Markdown
Author

EduPonz commented Mar 22, 2024

@Mergifyio backport 2.13.x 2.10.x 2.6.x

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 22, 2024 •
edited
Loading

backport 2.13.x 2.10.x 2.6.x

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Mar 22, 2024
@EduPonz @mergify
Run Github Ubuntu CI on PRs (#4598)
38df012 
* Refs #20679: Run Github Ubuntu CI on PRs

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20679: Fix remaining hidden overloads

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20679: Run CI on PRs to intermediate branches

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
(cherry picked from commit 7154a57)

# Conflicts:
#	.github/workflows/address-sanitizers.yaml
#	.github/workflows/documentation-tests.yaml
#	.github/workflows/mac-ci.yml
#	.github/workflows/thread-sanitizer.yaml
#	.github/workflows/windows-ci.yml
#	test/blackbox/common/BlackboxTestsDiscovery.cpp
mergify bot pushed a commit that referenced this pull request Mar 22, 2024
@EduPonz @mergify
Run Github Ubuntu CI on PRs (#4598)
e0c5dc5 
* Refs #20679: Run Github Ubuntu CI on PRs

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20679: Fix remaining hidden overloads

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20679: Run CI on PRs to intermediate branches

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
(cherry picked from commit 7154a57)

# Conflicts:
#	.github/workflows/address-sanitizers.yaml
#	.github/workflows/documentation-tests.yaml
#	.github/workflows/mac-ci.yml
#	.github/workflows/thread-sanitizer.yaml
#	.github/workflows/windows-ci.yml
#	src/cpp/statistics/rtps/monitor-service/MonitorServiceListener.hpp
#	test/blackbox/common/BlackboxTestsDiscovery.cpp
mergify bot pushed a commit that referenced this pull request Mar 22, 2024
@EduPonz @mergify
Run Github Ubuntu CI on PRs (#4598)
9c42ff2 
* Refs #20679: Run Github Ubuntu CI on PRs

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20679: Fix remaining hidden overloads

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20679: Run CI on PRs to intermediate branches

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
(cherry picked from commit 7154a57)

# Conflicts:
#	.github/workflows/address-sanitizers.yaml
#	.github/workflows/documentation-tests.yaml
#	.github/workflows/mac-ci.yml
#	.github/workflows/thread-sanitizer.yaml
#	.github/workflows/windows-ci.yml
#	src/cpp/fastdds/domain/DomainParticipantImpl.hpp
#	src/cpp/statistics/rtps/monitor-service/MonitorServiceListener.hpp
#	test/blackbox/common/BlackboxTestsDiscovery.cpp
This was referenced Mar 22, 2024
Closed
Closed
Closed
This was referenced Mar 26, 2024
Merged
Merged
Merged
@EduPonz EduPonz removed the ci-pending PR which CI is running label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

first-to-merge

Projects

None yet

Milestone

v2.14.1

Development

Successfully merging this pull request may close these issues.

2 participants

@EduPonz @JesusPoderoso