[20400] Test report action does not run when no-test label is set by EduPonz · Pull Request #4366 · eProsima/Fast-DDS

EduPonz · 2024-02-09T06:05:15Z

Description

This PR prevents the Github actions windows CI from attempting to create a test report if the label no-test is set

@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x

Contributor Checklist

Commit messages follow the project guidelines.
N/A: The code follows the style guidelines of this project.
N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A: Any new/modified methods have been properly documented using Doxygen.
N/A: Changes are ABI compatible.
N/A: Changes are API compatible.
N/A: New feature has been added to the versions.md file (if applicable).
N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

EduPonz · 2024-02-09T06:05:31Z

Cancelling rest of the CI to save resources

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

JesusPoderoso

LGTM with green CI

…eport step Signed-off-by: EduPonz <eduardoponz@eprosima.com>

.github/workflows/reusable-windows-ci.yml

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

MiguelCompany

LGTM with green CI 😜

* Refs #20400: Test report action does not run when no-test label is set Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20400: Add GTest cmake options to nightly.meta Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20400: Use test step conclusion to decide whether to run test report step Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20400: Apply Miguel's suggestion Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Fix and refactor Windows Github CI (#4356) * Refs #20318: Fix passing of RUNTIME_LIST to test discovery Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Refactor windows workflow Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Compile warnings as errors Signed-off-by: EduPonz <eduardoponz@eprosima.com> Refs #20318: Only use warnings as errors for Fast DDS Signed-off-by: EduPonz <eduardoponz@eprosima.com> Refs #20318: Do not override existing CXX_FLAGS Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Use thirdparty for Asio and TinyXML2 Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Add cancel-in-progress to sanitizer jobs Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Apply Ricardo's suggestions Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318. Avoid build error on default_macros_test Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20318: Adjust working dir for test report Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Uncrustify Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 7adc833) # Conflicts: # .github/workflows/config/default_ci.meta # .github/workflows/config/nightly.meta # .github/workflows/reusable-windows-ci.yml # cmake/testing/GoogleTest.cmake Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Fix conflicts Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Test report action does not run when no-test label is set (#4366) * Refs #20400: Test report action does not run when no-test label is set Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20400: Add GTest cmake options to nightly.meta Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20400: Use test step conclusion to decide whether to run test report step Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20400: Apply Miguel's suggestion Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318. Add GTEST_INDIVIDUAL=ON Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Add test summary step Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Use tagged version for test_reporter action Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20318: Enforce unique name for test artifacts Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

* Fix and refactor Windows Github CI (#4356) * Refs #20318: Fix passing of RUNTIME_LIST to test discovery Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Refactor windows workflow Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Compile warnings as errors Signed-off-by: EduPonz <eduardoponz@eprosima.com> Refs #20318: Only use warnings as errors for Fast DDS Signed-off-by: EduPonz <eduardoponz@eprosima.com> Refs #20318: Do not override existing CXX_FLAGS Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Use thirdparty for Asio and TinyXML2 Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Add cancel-in-progress to sanitizer jobs Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Apply Ricardo's suggestions Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318. Avoid build error on default_macros_test Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20318: Adjust working dir for test report Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Uncrustify Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 7adc833) Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Fix conflicts Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Test report action does not run when no-test label is set (#4366) * Refs #20400: Test report action does not run when no-test label is set Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20400: Add GTest cmake options to nightly.meta Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20400: Use test step conclusion to decide whether to run test report step Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20400: Apply Miguel's suggestion Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318. Add GTEST_INDIVIDUAL=ON Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Add test summary step Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Use tagged version for test_reporter action Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20318: Enforce unique name for test artifacts Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

* Fix and refactor Windows Github CI (#4356) * Refs #20318: Fix passing of RUNTIME_LIST to test discovery * Refs #20318: Refactor windows workflow * Refs #20318: Compile warnings as errors Refs #20318: Only use warnings as errors for Fast DDS Refs #20318: Do not override existing CXX_FLAGS * Refs #20318: Use thirdparty for Asio and TinyXML2 * Refs #20318: Add cancel-in-progress to sanitizer jobs * Refs #20318: Apply Ricardo's suggestions * Refs #20318. Avoid build error on default_macros_test * Refs #20318: Adjust working dir for test report * Refs #20318: Uncrustify --------- (cherry picked from commit 7adc833) * Fix conflicts * Test report action does not run when no-test label is set (#4366) * Refs #20400: Test report action does not run when no-test label is set * Refs #20400: Add GTest cmake options to nightly.meta * Refs #20400: Use test step conclusion to decide whether to run test report step * Refs #20400: Apply Miguel's suggestion --------- * Refs #20318. Add GTEST_INDIVIDUAL=ON * Refs #20318: Add test summary step * Use tagged version for test_reporter action * Refs #20318: Enforce unique name for test artifacts --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

* Fix and refactor Windows Github CI (#4356) * Fix and refactor Windows Github CI (#4356) * Refs #20318: Fix passing of RUNTIME_LIST to test discovery Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Refactor windows workflow Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Compile warnings as errors Signed-off-by: EduPonz <eduardoponz@eprosima.com> Refs #20318: Only use warnings as errors for Fast DDS Signed-off-by: EduPonz <eduardoponz@eprosima.com> Refs #20318: Do not override existing CXX_FLAGS Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Use thirdparty for Asio and TinyXML2 Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Add cancel-in-progress to sanitizer jobs Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Apply Ricardo's suggestions Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318. Avoid build error on default_macros_test Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20318: Adjust working dir for test report Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Uncrustify Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 7adc833) Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Fix conflicts Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Test report action does not run when no-test label is set (#4366) * Refs #20400: Test report action does not run when no-test label is set Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20400: Add GTest cmake options to nightly.meta Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20400: Use test step conclusion to decide whether to run test report step Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20400: Apply Miguel's suggestion Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318. Add GTEST_INDIVIDUAL=ON Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Add test summary step Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Use tagged version for test_reporter action Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20318: Enforce unique name for test artifacts Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20318: Set Fast CDR version for CI to 2.1.x branch Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Use GTEST_INDIVIDUAL=ON Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

* Fix and refactor Windows Github CI (#4356) * Fix and refactor Windows Github CI (#4356) * Refs #20318: Fix passing of RUNTIME_LIST to test discovery Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Refactor windows workflow Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Compile warnings as errors Signed-off-by: EduPonz <eduardoponz@eprosima.com> Refs #20318: Only use warnings as errors for Fast DDS Signed-off-by: EduPonz <eduardoponz@eprosima.com> Refs #20318: Do not override existing CXX_FLAGS Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Use thirdparty for Asio and TinyXML2 Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Add cancel-in-progress to sanitizer jobs Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Apply Ricardo's suggestions Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318. Avoid build error on default_macros_test Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20318: Adjust working dir for test report Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Uncrustify Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 7adc833) Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Fix conflicts Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Test report action does not run when no-test label is set (#4366) * Refs #20400: Test report action does not run when no-test label is set Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20400: Add GTest cmake options to nightly.meta Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20400: Use test step conclusion to decide whether to run test report step Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20400: Apply Miguel's suggestion Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318. Add GTEST_INDIVIDUAL=ON Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Add test summary step Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Use tagged version for test_reporter action Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20318: Enforce unique name for test artifacts Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20318: Install OpenSSL 1.1.1 Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

Refs #20400: Test report action does not run when no-test label is set

7b8d20d

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

EduPonz added the no-test Skip CI tests if PR marked with this label label Feb 9, 2024

EduPonz added this to the v2.13.2 milestone Feb 9, 2024

Refs #20400: Add GTest cmake options to nightly.meta

d13d9ad

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

JesusPoderoso previously approved these changes Feb 9, 2024

View reviewed changes

JesusPoderoso added the ci-pending PR which CI is running label Feb 9, 2024

Refs #20400: Use test step conclusion to decide whether to run test r…

a0fb86a

…eport step Signed-off-by: EduPonz <eduardoponz@eprosima.com>

EduPonz dismissed JesusPoderoso’s stale review via a0fb86a February 9, 2024 07:33

MiguelCompany requested changes Feb 9, 2024

View reviewed changes

.github/workflows/reusable-windows-ci.yml Outdated Show resolved Hide resolved

Refs #20400: Apply Miguel's suggestion

bd527a5

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

MiguelCompany approved these changes Feb 9, 2024

View reviewed changes

MiguelCompany merged commit f23a5be into master Feb 9, 2024

MiguelCompany deleted the hotfix/windows-ci-no-test branch February 9, 2024 09:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[20400] Test report action does not run when no-test label is set#4366

[20400] Test report action does not run when no-test label is set#4366
MiguelCompany merged 4 commits intomasterfrom
hotfix/windows-ci-no-test

EduPonz commented Feb 9, 2024 •

edited by MiguelCompany

Loading

Uh oh!

EduPonz commented Feb 9, 2024

Uh oh!

JesusPoderoso left a comment

Uh oh!

Uh oh!

MiguelCompany left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

EduPonz commented Feb 9, 2024 • edited by MiguelCompany Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

EduPonz commented Feb 9, 2024

Uh oh!

JesusPoderoso left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MiguelCompany left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

EduPonz commented Feb 9, 2024 •

edited by MiguelCompany

Loading