[20318] Fix and refactor Windows Github CI (backport #4356)#4361
Merged
[20318] Fix and refactor Windows Github CI (backport #4356)#4361
Conversation
7 tasks
MiguelCompany
previously approved these changes
Feb 8, 2024
66282d6 to
9516010
Compare
61def2d to
4a3c9e6
Compare
MiguelCompany
previously approved these changes
Feb 13, 2024
3 tasks
* Refs #20318: Fix passing of RUNTIME_LIST to test discovery Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Refactor windows workflow Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Compile warnings as errors Signed-off-by: EduPonz <eduardoponz@eprosima.com> Refs #20318: Only use warnings as errors for Fast DDS Signed-off-by: EduPonz <eduardoponz@eprosima.com> Refs #20318: Do not override existing CXX_FLAGS Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Use thirdparty for Asio and TinyXML2 Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Add cancel-in-progress to sanitizer jobs Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Apply Ricardo's suggestions Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318. Avoid build error on default_macros_test Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20318: Adjust working dir for test report Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20318: Uncrustify Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 7adc833) # Conflicts: # .github/workflows/config/default_ci.meta # .github/workflows/config/nightly.meta # .github/workflows/reusable-windows-ci.yml # cmake/testing/GoogleTest.cmake Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com>
* Refs #20400: Test report action does not run when no-test label is set Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20400: Add GTest cmake options to nightly.meta Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20400: Use test step conclusion to decide whether to run test report step Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20400: Apply Miguel's suggestion Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
dcd8953 to
0ce1edf
Compare
EduPonz
approved these changes
Feb 14, 2024
MiguelCompany
approved these changes
Feb 14, 2024
This was referenced Feb 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #4356 done by Mergify.
Cherry-pick of 7adc833 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com