Fix segfault when creating two participant with same fixed id [18051] by richiware · Pull Request #3443 · eProsima/Fast-DDS

richiware · 2023-04-10T10:24:45Z

"

Description

Second participant creation fails, but when its DomainParticipantImpl will be removed from the factory, the code remove the one of the first participant. This is because they share the same GUID.

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
Changes are ABI compatible.
Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
N/A Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.
"

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

test/unittest/dds/participant/ParticipantTests.cpp

src/cpp/rtps/RTPSDomain.cpp

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

src/cpp/rtps/RTPSDomainImpl.hpp

src/cpp/fastdds/domain/DomainParticipantImpl.cpp

test/unittest/dds/participant/ParticipantTests.cpp

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

MiguelCompany · 2023-04-11T06:05:10Z

@richiprosima Please test this

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

MiguelCompany · 2023-04-11T11:02:45Z

@richiprosima Please test this

MiguelCompany

LGTM with green CI

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

richiware · 2023-04-11T12:33:33Z

@richiprosima Please test this

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

richiware · 2023-04-11T14:07:32Z

@richiprosima Please test this

MiguelCompany

LGTM with green CI

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

richiware · 2023-04-12T06:00:58Z

@richiprosima Please test this

MiguelCompany

LGTM with green CI

MiguelCompany · 2023-04-12T09:27:35Z

@richiprosima Please test windows

richiware · 2023-04-12T13:14:37Z

@richiprosima Please test windows

JLBuenoLopez · 2023-06-27T13:36:35Z

@Mergifyio backport 2.9.x 2.6.x

mergify · 2023-06-27T13:36:40Z

backport 2.9.x 2.6.x

✅ Backports have been created

Details

#3628 Fix segfault when creating two participant with same fixed id [18051] (backport #3443) has been created for branch 2.9.x but encountered conflicts
#3629 Fix segfault when creating two participant with same fixed id [18051] (backport #3443) has been created for branch 2.6.x but encountered conflicts

* Refs #18050. Add regression test Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #18050. Fix segfault Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Apply suggestions from code review Co-authored-by: Miguel Company <miguelcompany@eprosima.com> * Refs #18050. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #18050. improvement regression test Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Apply suggestions from code review Co-authored-by: Miguel Company <miguelcompany@eprosima.com> * Refs #18051. Apply suggestions. Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #18051. Fix mock Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #18051. Fix statistics mock Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #18051. Fix uncrustify Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #18051. Fix memory leak Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 3a168ed) # Conflicts: # src/cpp/rtps/RTPSDomain.cpp # src/cpp/rtps/RTPSDomainImpl.hpp

* Refs #18050. Add regression test Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #18050. Fix segfault Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Apply suggestions from code review Co-authored-by: Miguel Company <miguelcompany@eprosima.com> * Refs #18050. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #18050. improvement regression test Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Apply suggestions from code review Co-authored-by: Miguel Company <miguelcompany@eprosima.com> * Refs #18051. Apply suggestions. Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #18051. Fix mock Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #18051. Fix statistics mock Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #18051. Fix uncrustify Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #18051. Fix memory leak Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 3a168ed) # Conflicts: # src/cpp/fastdds/domain/DomainParticipantImpl.cpp # src/cpp/rtps/RTPSDomain.cpp # src/cpp/rtps/RTPSDomainImpl.hpp

richiware added 2 commits April 10, 2023 12:34

Refs #18050. Add regression test

5118b56

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #18050. Fix segfault

4482d40

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

richiware force-pushed the bugfix/18050 branch from 770a285 to 4482d40 Compare April 10, 2023 10:34

richiware changed the title ~~Fix segfault when creating two participant with same fixed id~~ Fix segfault when creating two participant with same fixed id [18051] Apr 10, 2023

MiguelCompany added this to the v2.10.2 milestone Apr 10, 2023

MiguelCompany requested changes Apr 10, 2023

View reviewed changes

richiware and others added 3 commits April 10, 2023 16:10

Apply suggestions from code review

2c0302e

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

Refs #18050. Apply suggestions

5355856

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #18050. improvement regression test

c52b494

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

MiguelCompany requested changes Apr 10, 2023

View reviewed changes

richiware and others added 2 commits April 11, 2023 07:34

Apply suggestions from code review

7897564

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

Refs #18051. Apply suggestions.

3dcf51d

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

MiguelCompany previously approved these changes Apr 11, 2023

View reviewed changes

MiguelCompany added the ci-pending PR which CI is running label Apr 11, 2023

Refs #18051. Fix mock

eceabf0

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

richiware dismissed MiguelCompany’s stale review via eceabf0 April 11, 2023 09:43

MiguelCompany previously approved these changes Apr 11, 2023

View reviewed changes

Refs #18051. Fix statistics mock

3b12f56

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

richiware dismissed MiguelCompany’s stale review via 3b12f56 April 11, 2023 12:33

Refs #18051. Fix uncrustify

3055676

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

MiguelCompany previously approved these changes Apr 11, 2023

View reviewed changes

Refs #18051. Fix memory leak

3ab84f9

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

richiware dismissed MiguelCompany’s stale review via 3ab84f9 April 12, 2023 05:59

MiguelCompany approved these changes Apr 12, 2023

View reviewed changes

MiguelCompany added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Apr 12, 2023

richiware merged commit 3a168ed into master Apr 13, 2023

richiware deleted the bugfix/18050 branch April 13, 2023 05:32

This was referenced Jun 27, 2023

Fix segfault when creating two participant with same fixed id [18051] (backport #3443) #3628

Closed

Fix segfault when creating two participant with same fixed id [18051] (backport #3443) #3629

Closed

Conversation

richiware commented Apr 10, 2023 • edited by MiguelCompany Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MiguelCompany commented Apr 11, 2023

Uh oh!

MiguelCompany commented Apr 11, 2023

Uh oh!

MiguelCompany left a comment

Choose a reason for hiding this comment

Uh oh!

richiware commented Apr 11, 2023

Uh oh!

richiware commented Apr 11, 2023

Uh oh!

MiguelCompany left a comment

Choose a reason for hiding this comment

Uh oh!

richiware commented Apr 12, 2023

Uh oh!

MiguelCompany left a comment

Choose a reason for hiding this comment

Uh oh!

MiguelCompany commented Apr 12, 2023

Uh oh!

richiware commented Apr 12, 2023

Uh oh!

JLBuenoLopez commented Jun 27, 2023

Uh oh!

mergify bot commented Jun 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

richiware commented Apr 10, 2023 •

edited by MiguelCompany

Loading

mergify bot commented Jun 27, 2023 •

edited

Loading