Fix segfault when creating two participant with same fixed id [18051] (backport #3443)#3629
Closed
mergify[bot] wants to merge 1 commit into2.6.xfrom
Closed
Fix segfault when creating two participant with same fixed id [18051] (backport #3443)#3629mergify[bot] wants to merge 1 commit into2.6.xfrom
mergify[bot] wants to merge 1 commit into2.6.xfrom
Conversation
* Refs #18050. Add regression test Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #18050. Fix segfault Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Apply suggestions from code review Co-authored-by: Miguel Company <miguelcompany@eprosima.com> * Refs #18050. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #18050. improvement regression test Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Apply suggestions from code review Co-authored-by: Miguel Company <miguelcompany@eprosima.com> * Refs #18051. Apply suggestions. Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #18051. Fix mock Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #18051. Fix statistics mock Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #18051. Fix uncrustify Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #18051. Fix memory leak Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 3a168ed) # Conflicts: # src/cpp/fastdds/domain/DomainParticipantImpl.cpp # src/cpp/rtps/RTPSDomain.cpp # src/cpp/rtps/RTPSDomainImpl.hpp
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #3443 done by Mergify.
Cherry-pick of 3a168ed has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com