Skip to content

Fix repeated matched event notification#3396

Merged
MiguelCompany merged 2 commits intoeProsima:masterfrom
Barry-Xu-2018:topic-fix-repeated-matched-event-issue
Mar 30, 2023
Merged

Fix repeated matched event notification#3396
MiguelCompany merged 2 commits intoeProsima:masterfrom
Barry-Xu-2018:topic-fix-repeated-matched-event-issue

Conversation

@Barry-Xu-2018
Copy link
Copy Markdown
Contributor

@Barry-Xu-2018 Barry-Xu-2018 commented Mar 24, 2023

Description

Fixes #3395

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Barry-Xu-2018
Fix repeated matched event notification
9bd37ae 
Signed-off-by: Barry Xu <barry.xu@sony.com>
@Barry-Xu-2018 Barry-Xu-2018 mentioned this pull request Mar 24, 2023
Closed
1 task
MiguelCompany
MiguelCompany requested changes Mar 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just please the linters and we are good to go

Comment thread src/cpp/fastdds/publisher/DataWriterImpl.cpp Outdated
Comment thread src/cpp/fastdds/subscriber/DataReaderImpl.cpp Outdated
@MiguelCompany MiguelCompany added this to the v2.10.1 milestone Mar 24, 2023
@Barry-Xu-2018
Fix coding style
1ed9262 
Signed-off-by: Barry Xu <barry.xu@sony.com>
@MiguelCompany
Copy link
Copy Markdown
Member

MiguelCompany commented Mar 28, 2023

@richiprosima Please test this

@MiguelCompany MiguelCompany added the ci-pending PR which CI is running label Mar 28, 2023
@Barry-Xu-2018 Barry-Xu-2018 mentioned this pull request Mar 29, 2023
Merged
fujitatomoya
fujitatomoya approved these changes Mar 29, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fujitatomoya
Copy link
Copy Markdown
Contributor

fujitatomoya commented Mar 29, 2023

@MiguelCompany this blocks ros2/demos#607, please let us know what else needs to be done if there is.

@Barry-Xu-2018
Copy link
Copy Markdown
Contributor Author

Barry-Xu-2018 commented Mar 30, 2023

On Windows, the failed case is projectroot.test.blackbox.BlackboxTests_DDS_PIM.Discovery.RemoteBuiltinEndpointHonoring.
It checked heartbeat and acknack of reader and writer.
This patch should not affect their behavior.

@MiguelCompany MiguelCompany merged commit 8a5a916 into eProsima:master Mar 30, 2023
MiguelCompany added a commit that referenced this pull request Mar 31, 2023
@MiguelCompany
Fix regression introduced by #3396 (#3418)
7123d35 
* Refs #17919. Added regression test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17919. Fix DataReaderImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17919. Fix DataWriterImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
roscan-tech pushed a commit to roscan-tech/Fast-DDS that referenced this pull request Sep 6, 2024
@Barry-Xu-2018 @roscan-tech
Fix repeated matched event notification (eProsima#3396)
07e2d38 
* Fix repeated matched event notification

Signed-off-by: Barry Xu <barry.xu@sony.com>

* Fix coding style

Signed-off-by: Barry Xu <barry.xu@sony.com>

---------

Signed-off-by: Barry Xu <barry.xu@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

+1 more reviewer

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci-pending PR which CI is running

Projects

None yet

Milestone

v2.10.1

Development

Successfully merging this pull request may close these issues.

Repeated matched event notification

3 participants

@Barry-Xu-2018 @MiguelCompany @fujitatomoya