Skip to content

[17941] Fix regression introduced by #3396#3418

Merged
MiguelCompany merged 3 commits intomasterfrom
hotfix/3396-regression
Mar 31, 2023
Merged

[17941] Fix regression introduced by #3396#3418
MiguelCompany merged 3 commits intomasterfrom
hotfix/3396-regression

Conversation

@MiguelCompany
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany commented Mar 30, 2023 •
edited by richiware
Loading

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.
    • No need to backport since regression is only in master

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v2.10.1 milestone Mar 30, 2023
richiware
richiware previously approved these changes Mar 30, 2023
View reviewed changes
@MiguelCompany
Copy link
Copy Markdown
Member Author

MiguelCompany commented Mar 30, 2023

@richiprosima Please test this

@MiguelCompany
Refs #17919. Added regression test.
c5522a9 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #17919. Fix DataReaderImpl.
6f01e98 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #17919. Fix DataWriterImpl.
927ab3b 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany force-pushed the hotfix/3396-regression branch from 895889d to 927ab3b Compare March 31, 2023 05:44
@MiguelCompany
Copy link
Copy Markdown
Member Author

MiguelCompany commented Mar 31, 2023

@richiprosima Please test this

@MiguelCompany MiguelCompany requested a review from richiware March 31, 2023 06:44
@MiguelCompany MiguelCompany added the needs-review PR that is ready to be reviewed label Mar 31, 2023
@MiguelCompany MiguelCompany changed the title Fix regression introduced by #3396 [17941] Fix regression introduced by #3396 Mar 31, 2023
@MiguelCompany MiguelCompany merged commit 7123d35 into master Mar 31, 2023
@MiguelCompany MiguelCompany deleted the hotfix/3396-regression branch March 31, 2023 09:49
@MiguelCompany MiguelCompany mentioned this pull request Mar 31, 2023
Closed
1 task
@fujitatomoya fujitatomoya mentioned this pull request Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richiware richiware richiware approved these changes

Assignees

No one assigned

Labels

needs-review PR that is ready to be reviewed

Projects

None yet

Milestone

v2.10.1

Development

Successfully merging this pull request may close these issues.

2 participants

@MiguelCompany @richiware