[16736] Hotfix: change API name according to test plan review suggestion#3230
Merged
MiguelCompany merged 1 commit intofeature/on-unacknowledged-sample-removedfrom Jan 18, 2023
Conversation
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
MiguelCompany
approved these changes
Jan 18, 2023
JLBuenoLopez
added a commit
that referenced
this pull request
Jan 24, 2023
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
MiguelCompany
added a commit
that referenced
this pull request
Feb 8, 2023
…istener (#3275) * Add DataWriterListener on_unacknowledged_sample_removed callback (#3205) * Refs #16736: public API Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16736: add feature to versions.md Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16736: apply review suggestion Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Public RTPS API: RTPSWriter::has_been_delivered() (#3211) * Refs #16737: add new virtual method RTPSWriter::has_been_delivered Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: update versions.md Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: fix style Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Update RTPS API method name (#3230) Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * RTPSWriter::has_been_fully_delivered tests (#3233) * Refs #16736: extend RTPSWithRegistrationWriter to register flow controller Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16736: reorder headers, use fastdds headers instead of fastrtps ones Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16736: add reader data filter API to RTPSWithRegistrationWriter Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16736: send_sample method Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16736: expose has_been_fully_delivered API Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16736: add RTPSWriter::has_been_fully_delivered tests Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16736: linters Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: modify RTPS API Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16736: fix RTPSWriter::has_been_fully_delivered tests Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16736: fix RTPSWithRegistrationWriter has_been_delivered API Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16736: fix test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16736: fix waitForAllAcked timeout conversion Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16736: fix has_been_delivered tests Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> --------- Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * On unacknowledged sample removed tests (#3210) * Refs #16736: update namespaces (when possible) Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16736: add API to PubSubWriter Listener Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16736: save notified instance collection Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16736: add feature test suite Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16736: fix windows warnings Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16736: add listener tests according to changes introduced in the test plan during review process Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: fix tests with suggestions from test plan review Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: fix listener tests: ack race condition Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: avoid waiting and instead wait for ACK in listener tests Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16736: apply review suggestion Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> --------- Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * On unacknowledged sample removed implementation (#3240) * Refs #16737: ReaderProxy::has_been_delivered Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: add StatelessWriter::is_acked_by_all with sequence number as parameter Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: StatelessWriter::has_been_fully_delivered implementation Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: StatefulWriter::has_been_fully_delivered implementation Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: improve internal documentation Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: linters Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: add unacknowledged sample removed functor Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: fix DataWriterHistory mock Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: add auxiliary method change_is_acked_or_fully_delivered Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: fix StatefulWriter mock Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: notify if a change is removed unacknowledged Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: linters Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: safety check, ensure listener_ is not nullptr Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: add test to ensure that the notified DataWriter is the correct one Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: improve RTPSWithRegistrationWriter API to wait infinite for ack Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: improve reliable_has_been_fully_delivered test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: apply review suggestion: fix doxygen documentation Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: inject functor in DataWriterHistory constructor Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: refactor get_disable_positive_acks as virtual method of RTPSWriter Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: update versions.md with RTPSWriter::get_disable_positive_acks ABI break Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: apply review suggestions. Fix RTPSWriter mock Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: apply review suggestions concerning ReaderProxy::has_been_delivered Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: fix build Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: linters Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: fix Clang warning Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: increase timeout to ensure ACK reception Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: add ReaderProxy::has_been_delivered test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: apply review suggestions Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: apply review suggestion to ReaderProxyTests Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: fix Clang warning Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> --------- Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #15565: add regression test: Best Effort Writer with no matched Readers and change in the future Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #15565: apply review suggestion, fix to regression Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #15565: apply review suggestions Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Fix parameter in doxygen documentation. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> --------- Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After test plan review, the RTPS API method name was agreed to be changed from
RTPSWriter::has_been_deliveredtoRTPSWriter::has_been_fully_delivered.Contributor Checklist
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
N/A Fast DDS test suite has been run locally.
N/A Changes are ABI compatible.
N/A Documentation builds and tests pass locally.
N/A New feature has been added to the
versions.mdfile (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
N/A Applicable backports have been included in the description.
Reviewer Checklist