[15896] Fix selection of output locators by MiguelCompany · Pull Request #3003 · eProsima/Fast-DDS

MiguelCompany · 2022-10-07T11:36:53Z

Description

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
N/A Any new/modified methods have been properly documented using Doxygen.
Fast DDS test suite has been run locally.
Changes are ABI compatible.
Changes are API compatible.
N/A Documentation builds and tests pass locally.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

…y parent transport. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

…tors selected. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

…ack_nts_. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

MiguelCompany · 2022-10-10T09:51:12Z

@richiprosima Please test this

src/cpp/rtps/transport/test_UDPv4Transport.h

test/blackbox/api/fastrtps_deprecated/PubSubWriter.hpp

test/blackbox/api/fastrtps_deprecated/PubSubReader.hpp

test/blackbox/api/dds-pim/PubSubWriter.hpp

test/blackbox/api/dds-pim/PubSubReader.hpp

test/blackbox/common/BlackboxTestsDiscovery.cpp

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

MiguelCompany · 2022-10-13T07:56:55Z

@richiprosima Please test this

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

MiguelCompany · 2022-10-13T09:44:18Z

@richiprosima Please test this

MiguelCompany · 2022-10-13T12:48:17Z

@Mergifyio backport 2.7.x 2.6.x

* Refs #15839. Adding test_UDPv4Transport::should_drop_locator. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Adding destination locator filter to test_UDPv4Transport Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Avoid calling filters for packets that will be dropped by parent transport. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Add method set initial announcements to PubSubReader. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Add method set initial announcements to PubSubWriter. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Regression test added. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Call select_locators before asking on the number of locators selected. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Call select_locators before checking for global gap. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Do not reset locator selector inside deliver_sample_nts. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Avoid reseting locator selector on send_heartbeat_piggyback_nts_. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Improvements on StatelessWriter Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Improvements on StatefulWriter Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15896. Avoid arithmetic overflow on limitation check. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15896. Apply suggestions from code review. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15896. Add local filter for locators. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 23a788d) # Conflicts: # src/cpp/rtps/writer/StatelessWriter.cpp # test/blackbox/api/dds-pim/PubSubReader.hpp # test/blackbox/api/dds-pim/PubSubWriter.hpp # test/blackbox/api/fastrtps_deprecated/PubSubReader.hpp # test/blackbox/api/fastrtps_deprecated/PubSubWriter.hpp

mergify · 2022-10-13T12:49:19Z

backport 2.7.x 2.6.x

✅ Backports have been created

Details

#3010 [15896] Fix selection of output locators (backport #3003) has been created for branch 2.7.x
#3011 [15896] Fix selection of output locators (backport #3003) has been created for branch 2.6.x

* Fix selection of output locators (#3003) * Refs #15839. Adding test_UDPv4Transport::should_drop_locator. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Adding destination locator filter to test_UDPv4Transport Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Avoid calling filters for packets that will be dropped by parent transport. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Add method set initial announcements to PubSubReader. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Add method set initial announcements to PubSubWriter. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Regression test added. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Call select_locators before asking on the number of locators selected. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Call select_locators before checking for global gap. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Do not reset locator selector inside deliver_sample_nts. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Avoid reseting locator selector on send_heartbeat_piggyback_nts_. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Improvements on StatelessWriter Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Improvements on StatefulWriter Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15896. Avoid arithmetic overflow on limitation check. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15896. Apply suggestions from code review. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15896. Add local filter for locators. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 23a788d) # Conflicts: # src/cpp/rtps/writer/StatelessWriter.cpp # test/blackbox/api/dds-pim/PubSubReader.hpp # test/blackbox/api/dds-pim/PubSubWriter.hpp # test/blackbox/api/fastrtps_deprecated/PubSubReader.hpp # test/blackbox/api/fastrtps_deprecated/PubSubWriter.hpp * Refs #15896. Fix conflicts. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

MiguelCompany added 3 commits October 7, 2022 12:31

Refs #15839. Adding test_UDPv4Transport::should_drop_locator.

cfc42be

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Refs #15839. Adding destination locator filter to test_UDPv4Transport

625fc98

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Refs #15839. Avoid calling filters for packets that will be dropped b…

d3f421a

…y parent transport. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

MiguelCompany changed the title ~~Avoid sending data to locators of non-interested readers~~ Fix selection of output locators Oct 8, 2022

Refs #15839. Add method set initial announcements to PubSubReader.

fd09007

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

MiguelCompany force-pushed the bugfix/15839 branch from e9360ff to fe5fe14 Compare October 10, 2022 05:47

MiguelCompany added 6 commits October 10, 2022 09:56

Refs #15839. Add method set initial announcements to PubSubWriter.

beb803f

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Refs #15839. Regression test added.

9056ae3

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Refs #15839. Call select_locators before asking on the number of loca…

7dcb688

…tors selected. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Refs #15839. Call select_locators before checking for global gap.

e7c867c

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Refs #15839. Do not reset locator selector inside deliver_sample_nts.

d577046

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Refs #15839. Avoid reseting locator selector on send_heartbeat_piggyb…

d067a2d

…ack_nts_. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

MiguelCompany force-pushed the bugfix/15839 branch from fe5fe14 to d067a2d Compare October 10, 2022 07:56

MiguelCompany added 2 commits October 10, 2022 11:08

Refs #15839. Improvements on StatelessWriter

d60c827

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Refs #15839. Improvements on StatefulWriter

c23de20

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

MiguelCompany changed the title ~~Fix selection of output locators~~ [15896] Fix selection of output locators Oct 10, 2022

MiguelCompany requested a review from richiware October 10, 2022 10:23

richiware requested changes Oct 11, 2022

View reviewed changes

MiguelCompany added 2 commits October 13, 2022 07:59

Refs #15896. Avoid arithmetic overflow on limitation check.

acc6ef9

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Refs #15896. Apply suggestions from code review.

1ca6a92

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Refs #15896. Add local filter for locators.

f2b6be3

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

MiguelCompany force-pushed the bugfix/15839 branch from 8c544e4 to f2b6be3 Compare October 13, 2022 09:42

richiware approved these changes Oct 13, 2022

View reviewed changes

MiguelCompany merged commit 23a788d into master Oct 13, 2022

MiguelCompany deleted the bugfix/15839 branch October 13, 2022 12:47

mergify bot mentioned this pull request Oct 13, 2022

[15896] Fix selection of output locators (backport #3003) #3010

Merged

mergify bot mentioned this pull request Oct 13, 2022

[15896] Fix selection of output locators (backport #3003) #3011

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[15896] Fix selection of output locators#3003

[15896] Fix selection of output locators#3003
MiguelCompany merged 15 commits intomasterfrom
bugfix/15839

MiguelCompany commented Oct 7, 2022 •

edited by EduPonz

Loading

Uh oh!

MiguelCompany commented Oct 10, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MiguelCompany commented Oct 13, 2022

Uh oh!

MiguelCompany commented Oct 13, 2022

Uh oh!

MiguelCompany commented Oct 13, 2022

Uh oh!

mergify bot commented Oct 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

MiguelCompany commented Oct 7, 2022 • edited by EduPonz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

MiguelCompany commented Oct 10, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MiguelCompany commented Oct 13, 2022

Uh oh!

MiguelCompany commented Oct 13, 2022

Uh oh!

MiguelCompany commented Oct 13, 2022

Uh oh!

mergify bot commented Oct 13, 2022

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MiguelCompany commented Oct 7, 2022 •

edited by EduPonz

Loading