[15896] Fix selection of output locators (backport #3003)#3010
Merged
MiguelCompany merged 2 commits into2.7.xfrom Oct 15, 2022
Merged
[15896] Fix selection of output locators (backport #3003)#3010MiguelCompany merged 2 commits into2.7.xfrom
MiguelCompany merged 2 commits into2.7.xfrom
Conversation
* Refs #15839. Adding test_UDPv4Transport::should_drop_locator. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Adding destination locator filter to test_UDPv4Transport Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Avoid calling filters for packets that will be dropped by parent transport. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Add method set initial announcements to PubSubReader. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Add method set initial announcements to PubSubWriter. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Regression test added. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Call select_locators before asking on the number of locators selected. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Call select_locators before checking for global gap. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Do not reset locator selector inside deliver_sample_nts. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Avoid reseting locator selector on send_heartbeat_piggyback_nts_. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Improvements on StatelessWriter Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15839. Improvements on StatefulWriter Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15896. Avoid arithmetic overflow on limitation check. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15896. Apply suggestions from code review. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15896. Add local filter for locators. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 23a788d) # Conflicts: # src/cpp/rtps/writer/StatelessWriter.cpp # test/blackbox/api/dds-pim/PubSubReader.hpp # test/blackbox/api/dds-pim/PubSubWriter.hpp # test/blackbox/api/fastrtps_deprecated/PubSubReader.hpp # test/blackbox/api/fastrtps_deprecated/PubSubWriter.hpp
9 tasks
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Member
|
@richiprosima Please test this |
MiguelCompany
approved these changes
Oct 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #3003 done by Mergify.
Cherry-pick of 23a788d has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com