[14631] Unit tests for ExternalLocatorsProcessor#2974
Merged
MiguelCompany merged 18 commits intofeature/external-locators/mainfrom Sep 28, 2022
Merged
Conversation
8499c0d to
e01147f
Compare
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
…ipant. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
feb1c05 to
dbdb1d6
Compare
e01147f to
e316470
Compare
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany
added a commit
that referenced
this pull request
Sep 29, 2022
* Refs #14631. Adding new empty test on unittest/rtps/network. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Add source files to CMakeLists.txt Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Add default_locators to mock of ParticipantProxyData. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Test for add_external_locators_participant. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Test for add_external_locators on reader and writer. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Additional participant tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Additional endpoint tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Add separation comments. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Fixed locators string format. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Fixed order of arguments in add_external_locators_participant. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Reduce number of loops. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Matching locators scenario. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Data structures representing the scenario. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Added test matching_locators_scenario. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Increased cases on matching_locators_scenario. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Adding test for filtering a LocatorSelectorEntry. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Adding test for IP mask matching behavior. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Uncrustify. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
EduPonz
pushed a commit
that referenced
this pull request
Sep 29, 2022
* Refs #14631. Adding new empty test on unittest/rtps/network. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Add source files to CMakeLists.txt Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Add default_locators to mock of ParticipantProxyData. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Test for add_external_locators_participant. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Test for add_external_locators on reader and writer. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Additional participant tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Additional endpoint tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Add separation comments. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Fixed locators string format. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Fixed order of arguments in add_external_locators_participant. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Reduce number of loops. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Matching locators scenario. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Data structures representing the scenario. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Added test matching_locators_scenario. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Increased cases on matching_locators_scenario. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Adding test for filtering a LocatorSelectorEntry. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Adding test for IP mask matching behavior. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Uncrustify. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
MiguelCompany
added a commit
that referenced
this pull request
Sep 29, 2022
* Refs #14631. Adding new empty test on unittest/rtps/network. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Add source files to CMakeLists.txt Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Add default_locators to mock of ParticipantProxyData. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Test for add_external_locators_participant. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Test for add_external_locators on reader and writer. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Additional participant tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Additional endpoint tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Add separation comments. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Fixed locators string format. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Fixed order of arguments in add_external_locators_participant. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Reduce number of loops. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Matching locators scenario. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Data structures representing the scenario. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Added test matching_locators_scenario. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Increased cases on matching_locators_scenario. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Adding test for filtering a LocatorSelectorEntry. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Adding test for IP mask matching behavior. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Uncrustify. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
MiguelCompany
added a commit
that referenced
this pull request
Sep 29, 2022
* Adding empty implementation for ExternalLocatorsProcessor (#2815) * Refs #15017. ExternalLocatorsProcessor declaration. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15017. ExternalLocatorsProcessor empty definitions. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15017. Apply suggestions from code review. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Ricardo González <ricardo@richiware.dev> Co-authored-by: Ricardo González <ricardo@richiware.dev> * External locators XML parsing tests (#2902) * Refs #14631. Use StrictMock for log_mock on XMLProfileParserTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Adding basic structure for new test on XMLProfileParserTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Adding participant positive cases. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Adding participant negative cases. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Adding data_writer positive cases. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Adding data_reader positive cases. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Adding external locators to XMLParserParticipant test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Adding external locators to XMLParserPublisher test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Adding external locators to XMLParserSubscriber test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631: apply review suggestion Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #14631. Added more negative cases. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Unit tests for ExternalLocatorsProcessor (#2974) * Refs #14631. Adding new empty test on unittest/rtps/network. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Add source files to CMakeLists.txt Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Add default_locators to mock of ParticipantProxyData. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Test for add_external_locators_participant. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Test for add_external_locators on reader and writer. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Additional participant tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Additional endpoint tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Add separation comments. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Fixed locators string format. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Fixed order of arguments in add_external_locators_participant. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Reduce number of loops. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Matching locators scenario. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Data structures representing the scenario. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Added test matching_locators_scenario. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Increased cases on matching_locators_scenario. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Adding test for filtering a LocatorSelectorEntry. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Adding test for IP mask matching behavior. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #14631. Uncrustify. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * External locators implementation (#2822) * Refs #15017. Added mock for ExternalLocatorsProcessor. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15017. Processing new fields on wire_protocol QoS. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15017. Processing new fields on DataWriterQos. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15017. Processing new fields on DataReaderQos. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15017. Adding new elements to XSD. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15017. Processing external locator list XML element. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15017. XML parsing update of BuiltinAttributes. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15017. XML parsing update of ParticipantAttributes. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15017. XML parsing update of PublisherAttributes and SubscriberAttributes. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15017. Added participant interactions. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15017. Added reader creation interactions. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15017. Added writer creation interactions. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15017. Filter locators of discovered participant. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15017. Filter locators of discovered reader. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15017. Filter locators of discovered writer. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15017. Added implementation for ExternalLocatorsProcessor::add_external_locators. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15017. Added implementation for ExternalLocatorsProcessor::set_listening_locators. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15017. Implementations for ExternalLocatorsProcessor::filter_remote_locators delegate into internal function. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15017. Add function to check if two addresses match. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15017. Add function to check if two locators match. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15017. Implement filtering algorithm by sorting and then discarding. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15017. Setup external locators on builtin endpoints. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15017. Avoid duplicated tags inside <rtps>. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15017. Avoid duplicated tags inside <builtin>. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15017. Avoid duplicated tags inside publisher profiles. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15017. Avoid duplicated tags inside subscriber profiles. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15017. Avoid duplicated tags inside locator elements. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #15745. Updated versions.md Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: Ricardo González <ricardo@richiware.dev> Co-authored-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds unit tests for ExternalLocatorsProcessor
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist