Skip to content

[15017] Adding empty implementation for ExternalLocatorsProcessor#2815

Merged
MiguelCompany merged 3 commits intofeature/external-locators/mainfrom
feature/external-locators/internal-interfaces
Jul 20, 2022
Merged

[15017] Adding empty implementation for ExternalLocatorsProcessor#2815
MiguelCompany merged 3 commits intofeature/external-locators/mainfrom
feature/external-locators/internal-interfaces

Conversation

@MiguelCompany
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany commented Jul 6, 2022

Description

This PR adds an empty implementation for ExternalLocatorsProcessor, so we can add unit tests for it and, in parallel, prepare the implementation

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany
Refs #15017. ExternalLocatorsProcessor declaration.
f600829 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #15017. ExternalLocatorsProcessor empty definitions.
e4d4f45 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany added no-test Skip CI tests if PR marked with this label no-aarch Skip build & test for aarch64 labels Jul 6, 2022
@MiguelCompany MiguelCompany changed the base branch from master to feature/external-locators/main July 6, 2022 10:57
@MiguelCompany MiguelCompany mentioned this pull request Jul 7, 2022
Merged
10 tasks
richiware
richiware requested changes Jul 20, 2022
View reviewed changes
@MiguelCompany @richiware
Refs #15017. Apply suggestions from code review.
88b68a4 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Co-authored-by: Ricardo González <ricardo@richiware.dev>
@MiguelCompany MiguelCompany merged commit a312a47 into feature/external-locators/main Jul 20, 2022
@MiguelCompany MiguelCompany deleted the feature/external-locators/internal-interfaces branch July 20, 2022 11:02
MiguelCompany added a commit that referenced this pull request Jul 22, 2022
@MiguelCompany @richiware
Adding empty implementation for ExternalLocatorsProcessor (#2815)
43703ad 
* Refs #15017. ExternalLocatorsProcessor declaration.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. ExternalLocatorsProcessor empty definitions.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Apply suggestions from code review.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Co-authored-by: Ricardo González <ricardo@richiware.dev>

Co-authored-by: Ricardo González <ricardo@richiware.dev>
MiguelCompany added a commit that referenced this pull request Aug 1, 2022
@MiguelCompany @richiware
Adding empty implementation for ExternalLocatorsProcessor (#2815)
a235097 
* Refs #15017. ExternalLocatorsProcessor declaration.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. ExternalLocatorsProcessor empty definitions.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Apply suggestions from code review.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Co-authored-by: Ricardo González <ricardo@richiware.dev>

Co-authored-by: Ricardo González <ricardo@richiware.dev>
MiguelCompany added a commit that referenced this pull request Sep 8, 2022
@MiguelCompany @richiware
Adding empty implementation for ExternalLocatorsProcessor (#2815)
2d7d399 
* Refs #15017. ExternalLocatorsProcessor declaration.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. ExternalLocatorsProcessor empty definitions.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Apply suggestions from code review.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Co-authored-by: Ricardo González <ricardo@richiware.dev>

Co-authored-by: Ricardo González <ricardo@richiware.dev>
MiguelCompany added a commit that referenced this pull request Sep 28, 2022
@MiguelCompany @richiware
Adding empty implementation for ExternalLocatorsProcessor (#2815)
72a920f 
* Refs #15017. ExternalLocatorsProcessor declaration.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. ExternalLocatorsProcessor empty definitions.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Apply suggestions from code review.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Co-authored-by: Ricardo González <ricardo@richiware.dev>

Co-authored-by: Ricardo González <ricardo@richiware.dev>
MiguelCompany added a commit that referenced this pull request Sep 29, 2022
@MiguelCompany @richiware
Adding empty implementation for ExternalLocatorsProcessor (#2815)
1a82bc2 
* Refs #15017. ExternalLocatorsProcessor declaration.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. ExternalLocatorsProcessor empty definitions.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Apply suggestions from code review.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Co-authored-by: Ricardo González <ricardo@richiware.dev>

Co-authored-by: Ricardo González <ricardo@richiware.dev>
EduPonz pushed a commit that referenced this pull request Sep 29, 2022
@MiguelCompany @richiware @EduPonz
Adding empty implementation for ExternalLocatorsProcessor (#2815)
dd53d26 
* Refs #15017. ExternalLocatorsProcessor declaration.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. ExternalLocatorsProcessor empty definitions.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Apply suggestions from code review.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Co-authored-by: Ricardo González <ricardo@richiware.dev>

Co-authored-by: Ricardo González <ricardo@richiware.dev>
MiguelCompany added a commit that referenced this pull request Sep 29, 2022
@MiguelCompany @richiware
Adding empty implementation for ExternalLocatorsProcessor (#2815)
185fa9b 
* Refs #15017. ExternalLocatorsProcessor declaration.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. ExternalLocatorsProcessor empty definitions.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Apply suggestions from code review.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Co-authored-by: Ricardo González <ricardo@richiware.dev>

Co-authored-by: Ricardo González <ricardo@richiware.dev>
MiguelCompany added a commit that referenced this pull request Sep 29, 2022
@MiguelCompany @richiware @JLBuenoLopez
External locators feature (#2996)
2ce383d 
* Adding empty implementation for ExternalLocatorsProcessor (#2815)

* Refs #15017. ExternalLocatorsProcessor declaration.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. ExternalLocatorsProcessor empty definitions.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Apply suggestions from code review.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Co-authored-by: Ricardo González <ricardo@richiware.dev>

Co-authored-by: Ricardo González <ricardo@richiware.dev>

* External locators XML parsing tests (#2902)

* Refs #14631. Use StrictMock for log_mock on XMLProfileParserTests.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14631. Adding basic structure for new test on XMLProfileParserTests.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14631. Adding participant positive cases.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14631. Adding participant negative cases.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14631. Adding data_writer positive cases.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14631. Adding data_reader positive cases.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14631. Adding external locators to XMLParserParticipant test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14631. Adding external locators to XMLParserPublisher test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14631. Adding external locators to XMLParserSubscriber test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14631: apply review suggestion

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #14631. Added more negative cases.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Co-authored-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Unit tests for ExternalLocatorsProcessor (#2974)

* Refs #14631. Adding new empty test on unittest/rtps/network.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14631. Add source files to CMakeLists.txt

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14631. Add default_locators to mock of ParticipantProxyData.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14631. Test for add_external_locators_participant.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14631. Test for add_external_locators on reader and writer.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14631. Additional participant tests.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14631. Additional endpoint tests.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14631. Add separation comments.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14631. Fixed locators string format.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14631. Fixed order of arguments in add_external_locators_participant.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14631. Reduce number of loops.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14631. Matching locators scenario.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14631. Data structures representing the scenario.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14631. Added test matching_locators_scenario.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14631. Increased cases on matching_locators_scenario.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14631. Adding test for filtering a LocatorSelectorEntry.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14631. Adding test for IP mask matching behavior.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14631. Uncrustify.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Co-authored-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* External locators implementation (#2822)

* Refs #15017. Added mock for ExternalLocatorsProcessor.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Processing new fields on wire_protocol QoS.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Processing new fields on DataWriterQos.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Processing new fields on DataReaderQos.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Adding new elements to XSD.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Processing external locator list XML element.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. XML parsing update of BuiltinAttributes.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. XML parsing update of ParticipantAttributes.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. XML parsing update of PublisherAttributes and SubscriberAttributes.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Added participant interactions.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Added reader creation interactions.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Added writer creation interactions.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Filter locators of discovered participant.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Filter locators of discovered reader.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Filter locators of discovered writer.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Added implementation for ExternalLocatorsProcessor::add_external_locators.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Added implementation for ExternalLocatorsProcessor::set_listening_locators.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Implementations for ExternalLocatorsProcessor::filter_remote_locators delegate into internal function.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Add function to check if two addresses match.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Add function to check if two locators match.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Implement filtering algorithm by sorting and then discarding.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Setup external locators on builtin endpoints.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Avoid duplicated tags inside <rtps>.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Avoid duplicated tags inside <builtin>.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Avoid duplicated tags inside publisher profiles.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Avoid duplicated tags inside subscriber profiles.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15017. Avoid duplicated tags inside locator elements.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #15745. Updated versions.md

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Co-authored-by: Ricardo González <ricardo@richiware.dev>
Co-authored-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richiware richiware richiware approved these changes

Assignees

No one assigned

Labels

no-aarch Skip build & test for aarch64 no-test Skip CI tests if PR marked with this label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MiguelCompany @richiware