Skip to content

fix(env):allow underscore in env name #1011#1015

Merged
pedro-psb merged 1 commit intomasterfrom
1011
Oct 19, 2023
Merged

fix(env):allow underscore in env name #1011#1015
pedro-psb merged 1 commit intomasterfrom
1011

Conversation

@rochacbruno
Copy link
Copy Markdown
Member

Revert change added in #830, I was not able to find the reason for the change

The env name must allow _

Fix #1011

@netlify
Copy link
Copy Markdown

netlify bot commented Oct 19, 2023

Deploy Preview for dynaconf ready!

Name Link
🔨 Latest commit e31c846
🔍 Latest deploy log https://app.netlify.com/sites/dynaconf/deploys/65319118d807af000810c80c
😎 Deploy Preview https://deploy-preview-1015--dynaconf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rochacbruno rochacbruno requested a review from pedro-psb October 19, 2023 20:05
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 19, 2023

Test Results (Python 3.11)

473 tests  ±0   473 ✔️ ±0   53s ⏱️ -5s
    1 suites ±0       0 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit e31c846. ± Comparison against base commit f2bb032.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
tests.test_base ‑ test_env_should_not_have_underline
tests.test_base ‑ test_env_should_allow_underline

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 19, 2023

Test Results (Python 3.8)

473 tests  ±0   473 ✔️ ±0   41s ⏱️ ±0s
    1 suites ±0       0 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit e31c846. ± Comparison against base commit f2bb032.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
tests.test_base ‑ test_env_should_not_have_underline
tests.test_base ‑ test_env_should_allow_underline

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 19, 2023

Test Results (Python 3.10)

473 tests  ±0   473 ✔️ ±0   43s ⏱️ -8s
    1 suites ±0       0 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit e31c846. ± Comparison against base commit f2bb032.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
tests.test_base ‑ test_env_should_not_have_underline
tests.test_base ‑ test_env_should_allow_underline

♻️ This comment has been updated with latest results.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 19, 2023

Codecov Report

Merging #1015 (e31c846) into master (f2bb032) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1015   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files          23       23           
  Lines        2248     2248           
=======================================
  Hits         2220     2220           
  Misses         28       28           
Files Coverage Δ
dynaconf/base.py 99.81% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pedro-psb pedro-psb merged commit f55c277 into master Oct 19, 2023
@rochacbruno rochacbruno deleted the 1011 branch October 19, 2023 23:36
pedro-psb added a commit to pedro-psb/dynaconf that referenced this pull request Oct 31, 2023
Shortlog of commit since last release:

    Bruno Rocha (2):
          Release version 3.2.3
          fix(env): allow underscore in env name dynaconf#1011 (dynaconf#1015)

    Jake Callahan (1):
          fix(vault): pin hvac minimum version

    Pedro Pessoa (3):
          fix(set): non-str key raising type error dynaconf#1005 (dynaconf#1008)
          fix(merge): dynaconf_merge=False on nested structures (dynaconf#1012)
          fix(cli): support for 'entrypoint-path' in FLASK_APP dynaconf#946 (dynaconf#1014)

    Sebastian Correa (1):
          doc(validation): Improve Configuration and Validation sections of the docs (dynaconf#989)

    Vladislav Sharapov (1):
          doc(envvars): Fix link to configuration page (dynaconf#1020)
pedro-psb added a commit to pedro-psb/dynaconf that referenced this pull request Nov 19, 2023
Shortlog of commit since last release:

    Bruno Rocha (2):
          Release version 3.2.3
          fix(env): allow underscore in env name dynaconf#1011 (dynaconf#1015)

    Jake Callahan (1):
          fix(vault): pin hvac minimum version

    Pedro Pessoa (3):
          fix(set): non-str key raising type error dynaconf#1005 (dynaconf#1008)
          fix(merge): dynaconf_merge=False on nested structures (dynaconf#1012)
          fix(cli): support for 'entrypoint-path' in FLASK_APP dynaconf#946 (dynaconf#1014)

    Sebastian Correa (1):
          doc(validation): Improve Configuration and Validation sections of the docs (dynaconf#989)

    Vladislav Sharapov (1):
          doc(envvars): Fix link to configuration page (dynaconf#1020)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] environments can no longer have _ in their name

2 participants