Skip to content

fix(cli): support for 'entrypoint-path' in FLASK_APP #946#1014

Merged
rochacbruno merged 1 commit intodynaconf:masterfrom
pedro-psb:946/flask-cli
Oct 19, 2023
Merged

fix(cli): support for 'entrypoint-path' in FLASK_APP #946#1014
rochacbruno merged 1 commit intodynaconf:masterfrom
pedro-psb:946/flask-cli

Conversation

@pedro-psb
Copy link
Copy Markdown
Member

Dynaconf CLI wouldn't recognize FLASK_APP=<path>, where path syntax is like foo.bar:app ('entrypoint-format').

This adds support for that by passing the FLASK_APP value to Flask itself to handle, as suggested in #946.

@COUR4G3 Thanks for the good notes about the problem.

@netlify
Copy link
Copy Markdown

netlify bot commented Oct 19, 2023

Deploy Preview for dynaconf ready!

Name Link
🔨 Latest commit 7690aca
🔍 Latest deploy log https://app.netlify.com/sites/dynaconf/deploys/65313d4bc293ad00087844f8
😎 Deploy Preview https://deploy-preview-1014--dynaconf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 19, 2023

Codecov Report

Merging #1014 (7690aca) into master (b113e74) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1014   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files          23       23           
  Lines        2248     2248           
=======================================
  Hits         2220     2220           
  Misses         28       28           
Files Coverage Δ
dynaconf/cli.py 99.27% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rochacbruno rochacbruno merged commit f2bb032 into dynaconf:master Oct 19, 2023
pedro-psb added a commit to pedro-psb/dynaconf that referenced this pull request Oct 31, 2023
Shortlog of commit since last release:

    Bruno Rocha (2):
          Release version 3.2.3
          fix(env): allow underscore in env name dynaconf#1011 (dynaconf#1015)

    Jake Callahan (1):
          fix(vault): pin hvac minimum version

    Pedro Pessoa (3):
          fix(set): non-str key raising type error dynaconf#1005 (dynaconf#1008)
          fix(merge): dynaconf_merge=False on nested structures (dynaconf#1012)
          fix(cli): support for 'entrypoint-path' in FLASK_APP dynaconf#946 (dynaconf#1014)

    Sebastian Correa (1):
          doc(validation): Improve Configuration and Validation sections of the docs (dynaconf#989)

    Vladislav Sharapov (1):
          doc(envvars): Fix link to configuration page (dynaconf#1020)
pedro-psb added a commit to pedro-psb/dynaconf that referenced this pull request Nov 19, 2023
Shortlog of commit since last release:

    Bruno Rocha (2):
          Release version 3.2.3
          fix(env): allow underscore in env name dynaconf#1011 (dynaconf#1015)

    Jake Callahan (1):
          fix(vault): pin hvac minimum version

    Pedro Pessoa (3):
          fix(set): non-str key raising type error dynaconf#1005 (dynaconf#1008)
          fix(merge): dynaconf_merge=False on nested structures (dynaconf#1012)
          fix(cli): support for 'entrypoint-path' in FLASK_APP dynaconf#946 (dynaconf#1014)

    Sebastian Correa (1):
          doc(validation): Improve Configuration and Validation sections of the docs (dynaconf#989)

    Vladislav Sharapov (1):
          doc(envvars): Fix link to configuration page (dynaconf#1020)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants